From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Anthony Krowiak <akrowiak@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: jjherne@linux.ibm.com, borntraeger@de.ibm.com,
pasic@linux.ibm.com, alex@shazbot.org, kwankhede@nvidia.com,
fiuczy@linux.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, agordeev@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/8] s390/vfio-ap: Fix stale do_remove flag across iterations in vfio_ap_mdev_cfg_remove
Date: Tue, 11 Aug 2026 10:57:10 -0400 [thread overview]
Message-ID: <5e0c6818-b96d-4c16-85ec-856d880e7ce8@linux.ibm.com> (raw)
In-Reply-To: <20260810192257.1208410-2-akrowiak@linux.ibm.com>
On 8/10/26 3:22 PM, Anthony Krowiak wrote:
> The do_remove flag in vfio_ap_mdev_cfg_remove() is initialised to zero
> before the loop that iterates over the list of matrix mdevs, but is
> never reset at the start of each iteration. Since do_remove is
> OR-accumulated across iterations, a positive result from one mdev
> carries over to subsequent mdevs.
>
> The fix is to set the do_remove flag with the first call to bitmap_and;
> for example: do_remove = bitmap_an rather than do_remove |= bitmap_and.
>
> Fixes: eeb386aeb5b7 ("s390/vfio-ap: handle config changed and scan complete notification")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anthony Krowiak <akrowiak@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
next prev parent reply other threads:[~2026-08-11 14:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 19:22 [PATCH v2 0/8] s390/vfio-ap: Fix bugs in vfio_ap device driver callback functions Anthony Krowiak
2026-08-10 19:22 ` [PATCH v2 1/8] s390/vfio-ap: Fix stale do_remove flag across iterations in vfio_ap_mdev_cfg_remove Anthony Krowiak
2026-08-11 14:57 ` Matthew Rosato [this message]
2026-08-10 19:22 ` [PATCH v2 2/8] s390/vfio-ap: Fix dereference matrix_mdev->kvm without checking for NULL Anthony Krowiak
2026-08-11 15:53 ` Matthew Rosato
2026-08-10 19:22 ` [PATCH v2 3/8] s390/vfio-ap: Fix use of wrong lock in mdev probe function Anthony Krowiak
2026-08-11 15:58 ` Matthew Rosato
2026-08-11 18:42 ` Anthony Krowiak
2026-08-11 18:44 ` Matthew Rosato
2026-08-11 18:53 ` Anthony Krowiak
2026-08-10 19:22 ` [PATCH v2 4/8] s390/vfio-ap: Fix required lock not held during update of ap_matrix_mdev object Anthony Krowiak
2026-08-11 16:38 ` Matthew Rosato
2026-08-10 19:22 ` [PATCH v2 5/8] s390/vfio-ap: Fix control domain removal in vfio_ap_mdev_cfg_remove Anthony Krowiak
2026-08-11 17:14 ` Matthew Rosato
2026-08-10 19:22 ` [PATCH v2 6/8] s390/vfio-ap: fix potential use of uninitialized apm_filtered bitmap Anthony Krowiak
2026-08-11 18:02 ` Matthew Rosato
2026-08-11 19:24 ` Anthony Krowiak
2026-08-10 19:22 ` [PATCH v2 7/8] s390/vfio-ap: Fix required lock not held during display of sysfs status attribute Anthony Krowiak
2026-08-11 18:03 ` Matthew Rosato
2026-08-11 18:20 ` Matthew Rosato
2026-08-11 18:51 ` Anthony Krowiak
2026-08-11 18:55 ` Matthew Rosato
2026-08-11 20:19 ` Anthony Krowiak
2026-08-11 18:43 ` Anthony Krowiak
2026-08-10 19:22 ` [PATCH v2 8/8] s390/vfio-ap: Fix hot-unplug skipped when last AP adapter or domain removed Anthony Krowiak
2026-08-11 20:43 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0c6818-b96d-4c16-85ec-856d880e7ce8@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=borntraeger@de.ibm.com \
--cc=fiuczy@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®