From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable
Date: Wed, 21 Sep 2022 17:19:26 +0200 [thread overview]
Message-ID: <5e34eadc-ef6a-abeb-6bce-347593c275b7@linaro.org> (raw)
In-Reply-To: <fd74e77c-f3d3-1f09-2e5a-0a94e2a3eeea@linux.intel.com>
On 21/09/2022 17:11, Pierre-Louis Bossart wrote:
>>>> /**
>>>> * slim_stream_unprepare() - Un-prepare a SLIMbus Stream
>>>> *
>>>> * @stream: instance of slim stream runtime to unprepare
>>>> *
>>>> * This API will un allocate all the ports and channels associated with
>>>> * SLIMbus stream
>>>
>>> You mean this piece of doc? Indeed looks inaccurate. I'll update it.
>>
>> Wait, no, this is correct. Please point to what is wrong in kernel doc.
>> I don't see it. :(
>
> the TRIGGER_STOP and TRIGGER_PAUSE_PUSH do the same thing. There is no
> specific mapping of disable() to TRIGGER_STOP and unprepare() to
> TRIGGER_PAUSE_PUSH as the documentation hints at.
Which TRIGGER_STOP and TRIGGER_PAUSE_PUSH? In one specific codec driver?
If yes, I don't think Slimbus documentation should care how actual users
implement it (e.g. coalesce states).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-21 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 14:53 Krzysztof Kozlowski
2022-09-21 14:53 ` [PATCH 2/2] ASoC: wcd934x: " Krzysztof Kozlowski
2022-09-22 21:38 ` Srinivas Kandagatla
2022-09-21 15:05 ` [PATCH 1/2] ASoC: wcd9335: " Pierre-Louis Bossart
2022-09-21 15:06 ` Krzysztof Kozlowski
2022-09-21 15:08 ` Krzysztof Kozlowski
2022-09-21 15:11 ` Pierre-Louis Bossart
2022-09-21 15:19 ` Krzysztof Kozlowski [this message]
2022-09-21 15:25 ` Pierre-Louis Bossart
2022-09-21 15:28 ` Krzysztof Kozlowski
2022-09-22 21:38 ` Srinivas Kandagatla
2022-09-23 17:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e34eadc-ef6a-abeb-6bce-347593c275b7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®