From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Yang Shi <shy828301@gmail.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"hch@infradead.org" <hch@infradead.org>
Subject: Re: [v6 PATCH] block: introduce block_rq_error tracepoint
Date: Sat, 5 Feb 2022 09:12:29 +0000 [thread overview]
Message-ID: <5eac186c-918a-87d6-8cc7-85d4d24c4837@nvidia.com> (raw)
In-Reply-To: <CAHbLzko1izwBERS6auEna+eAGzQVA7zkDihMjT=tt_EBdhfmaA@mail.gmail.com>
>> since if I remember correctly we need to define a event class
>> instead of duplicating a tracepoint with similar reporting.
>
> Very good point. I did overlook it. The original post did have disk
> name and didn't have cmd, now the two tracepoints look much more
> similar than the original post, so I agree the duplicate could be
> combined into an event class.
>
I sent out a V7 with a prep patch and testlog keeping your
original authorship from this patch.
If you find anything wrong with that please send out V8 on the
top of V7.
>>
>> -ck
>>
>>
prev parent reply other threads:[~2022-02-05 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 20:12 Yang Shi
2022-02-04 2:46 ` Chaitanya Kulkarni
2022-02-04 8:35 ` Chaitanya Kulkarni
2022-02-04 18:10 ` Yang Shi
2022-02-04 18:08 ` Yang Shi
2022-02-05 9:12 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eac186c-918a-87d6-8cc7-85d4d24c4837@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shy828301@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®