* [PATCH] ata: Remove redundant dev_err()
@ 2026-07-10 11:02 Pan Chuang
2026-07-10 14:36 ` Hannes Reinecke
2026-07-13 7:46 ` Damien Le Moal
0 siblings, 2 replies; 3+ messages in thread
From: Pan Chuang @ 2026-07-10 11:02 UTC (permalink / raw)
To: Damien Le Moal, Niklas Cassel,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/ata/pata_mpc52xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
index 210a63283f62..1739743427cf 100644
--- a/drivers/ata/pata_mpc52xx.c
+++ b/drivers/ata/pata_mpc52xx.c
@@ -769,10 +769,8 @@ static int mpc52xx_ata_probe(struct platform_device *op)
task_irq = bcom_get_task_irq(dmatsk);
rv = devm_request_irq(&op->dev, task_irq, &mpc52xx_ata_task_irq, 0,
"ATA task", priv);
- if (rv) {
- dev_err(&op->dev, "error requesting DMA IRQ\n");
+ if (rv)
goto err2;
- }
priv->dmatsk = dmatsk;
/* Init the hw */
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ata: Remove redundant dev_err()
2026-07-10 11:02 [PATCH] ata: Remove redundant dev_err() Pan Chuang
@ 2026-07-10 14:36 ` Hannes Reinecke
2026-07-13 7:46 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2026-07-10 14:36 UTC (permalink / raw)
To: Pan Chuang, Damien Le Moal, Niklas Cassel,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On 7/10/26 1:02 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/ata/pata_mpc52xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 210a63283f62..1739743427cf 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -769,10 +769,8 @@ static int mpc52xx_ata_probe(struct platform_device *op)
> task_irq = bcom_get_task_irq(dmatsk);
> rv = devm_request_irq(&op->dev, task_irq, &mpc52xx_ata_task_irq, 0,
> "ATA task", priv);
> - if (rv) {
> - dev_err(&op->dev, "error requesting DMA IRQ\n");
> + if (rv)
> goto err2;
> - }
> priv->dmatsk = dmatsk;
>
> /* Init the hw */
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ata: Remove redundant dev_err()
2026-07-10 11:02 [PATCH] ata: Remove redundant dev_err() Pan Chuang
2026-07-10 14:36 ` Hannes Reinecke
@ 2026-07-13 7:46 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2026-07-13 7:46 UTC (permalink / raw)
To: Pan Chuang, Niklas Cassel,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On 7/10/26 20:02, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Applied to for-7.3 with some corrections to the commit title and message.
Thanks!
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-13 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-10 11:02 [PATCH] ata: Remove redundant dev_err() Pan Chuang
2026-07-10 14:36 ` Hannes Reinecke
2026-07-13 7:46 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome