From: Javier Martinez Canillas <javierm@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel <dri-devel@lists.freedesktop.org>,
Peter Robinson <pbrobinson@gmail.com>,
Mark Brown <broonie@kernel.org>,
kernel test robot <lkp@intel.com>, Borislav Petkov <bp@suse.de>,
Colin Ian King <colin.king@canonical.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Dinh Nguyen <dinguyen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures
Date: Tue, 27 Jul 2021 13:54:17 +0200 [thread overview]
Message-ID: <5ee9e008-a395-56c2-f57f-e3567d6b648b@redhat.com> (raw)
In-Reply-To: <CAMuHMdX+hsXeoY8jNdDvyiw2HxhwcQw60LJddsaOGZBcHT=a=A@mail.gmail.com>
Hello Geert,
On 7/27/21 1:39 PM, Geert Uytterhoeven wrote:
[snip]
>>> Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA,
>>> and FB_EFI?
>>
>> It's another option, yes. I just thought that the use of select was not
>> encouraged and using depends was less fragile / error prone.
>
> Select is very useful for config symbols that are invisible to the user (i.e.
> cannot be enabled/disabled manually).
>
Got it. I don't have a strong opinion on this really. In fact, the first
version of the patch did use select for the arches but I got as feedback
that should use depends instead:
https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg351961.html
Granted, that was for the arches but you are proposing to do it for the
drivers that match against the platform devices registered by sysfb. So
it does make more sense to what I did in v1.
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2021-07-27 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 9:30 Javier Martinez Canillas
2021-07-27 9:50 ` Daniel Vetter
2021-07-27 10:03 ` Geert Uytterhoeven
2021-07-27 10:22 ` Javier Martinez Canillas
2021-07-27 11:17 ` Geert Uytterhoeven
2021-07-27 11:32 ` Javier Martinez Canillas
2021-07-27 11:39 ` Geert Uytterhoeven
2021-07-27 11:54 ` Javier Martinez Canillas [this message]
2021-07-27 11:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee9e008-a395-56c2-f57f-e3567d6b648b@redhat.com \
--to=javierm@redhat.com \
--cc=bp@suse.de \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dinguyen@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nsaenz@kernel.org \
--cc=pbrobinson@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®