Re: [PATCH 2/4] arm64: dts: qcom: lemans: add mdss1 displayPort device nodes

[Mani Chandana Kuntumalla <quic_mkuntuma@quicinc.com>]

On 10/8/2025 6:10 PM, Konrad Dybcio wrote:
> On 9/26/25 10:59 AM, Mani Chandana Ballary Kuntumalla wrote:
>> Add device tree nodes for the mdss1 DPTX0 and DPTX1 controllers
>> with their corresponding PHYs.
>>
>> Signed-off-by: Mani Chandana Ballary Kuntumalla <quic_mkuntuma@quicinc.com>
>> ---
> 
> [...]
> 
>> +			mdss1_dp0: displayport-controller@22154000 {
>> +				compatible = "qcom,sa8775p-dp";
>> +
>> +				reg = <0x0 0x22154000 0x0 0x104>,
> 
> sz = 0x200
> 
>> +				      <0x0 0x22154200 0x0 0x0c0>,
> 
> sz = 0x200
> 
>> +				      <0x0 0x22155000 0x0 0x770>,
> 
> sz = 0xc00> +				      <0x0 0x22156000 0x0 0x09c>,
>> +				      <0x0 0x22157000 0x0 0x09c>,
>> +				      <0x0 0x22158000 0x0 0x09c>,
>> +				      <0x0 0x22159000 0x0 0x09c>,
> 
> sz = 0x400 for all 0x9c
> 
>> +				      <0x0 0x2215a000 0x0 0x23c>,
>> +				      <0x0 0x2215b000 0x0 0x23c>;
> 
> 0x23c -> 0x600
> 
> [...]
> 
> 
>> +			mdss1_dp1: displayport-controller@2215c000 {
>> +				compatible = "qcom,sa8775p-dp";
>> +
>> +				reg = <0x0 0x2215c000 0x0 0x104>,
>> +				      <0x0 0x2215c200 0x0 0x0c0>,
>> +				      <0x0 0x2215d000 0x0 0x770>,
>> +				      <0x0 0x2215e000 0x0 0x09c>,
>> +				      <0x0 0x2215f000 0x0 0x09c>,
>> +				      <0x0 0x22160000 0x0 0x09c>,
>> +				      <0x0 0x22161000 0x0 0x09c>,
>> +				      <0x0 0x22162000 0x0 0x23c>,
>> +				      <0x0 0x22163000 0x0 0x23c>;
> 
> 0x2216_2000 and _3000 don't exist, there's no MST2/3
> 
> sizes should be changed similarly

MST2/3 is supported for MDSS1 DPTX0.

> 
> [...]
> 
>>   		dispcc1: clock-controller@22100000 {
>> @@ -6872,6 +7115,8 @@ dispcc1: clock-controller@22100000 {
>>   				 <&rpmhcc RPMH_CXO_CLK>,
>>   				 <&rpmhcc RPMH_CXO_CLK_A>,
>>   				 <&sleep_clk>,
>> +				 <&mdss1_dp0_phy 0>, <&mdss1_dp0_phy 1>,
>> +				 <&mdss1_dp1_phy 0>, <&mdss1_dp1_phy 1>,
>>   				 <0>, <0>, <0>, <0>,
> 
> You need to remove the same amount of zeroes that you added
> 

Sure, Will update this in the next version.

> Konrad
> 
>>   				 <0>, <0>, <0>, <0>;
>>   			power-domains = <&rpmhpd SA8775P_MMCX>;