mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mani Chandana Ballary Kuntumalla <quic_mkuntuma@quicinc.com>,
	dmitry.baryshkov@oss.qualcomm.com, marijn.suijten@somainline.org,
	swboyd@chromium.org, mripard@kernel.org, abel.vesa@linaro.org,
	andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	robin.clark@oss.qualcomm.com, jessica.zhang@oss.qualcomm.com,
	abhinav.kumar@linux.dev, sean@poorly.run, airlied@gmail.com,
	simona@ffwll.ch, alex.vinarskis@gmail.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com,
	quic_riteshk@quicnic.com, quic_amitsi@quicnic.com
Subject: Re: [PATCH 2/4] arm64: dts: qcom: lemans: add mdss1 displayPort device nodes
Date: Wed, 8 Oct 2025 14:40:35 +0200	[thread overview]
Message-ID: <e3400ab5-c4ea-455a-b8ea-d4fba2ece85d@oss.qualcomm.com> (raw)
In-Reply-To: <20250926085956.2346179-3-quic_mkuntuma@quicinc.com>

On 9/26/25 10:59 AM, Mani Chandana Ballary Kuntumalla wrote:
> Add device tree nodes for the mdss1 DPTX0 and DPTX1 controllers
> with their corresponding PHYs.
> 
> Signed-off-by: Mani Chandana Ballary Kuntumalla <quic_mkuntuma@quicinc.com>
> ---

[...]

> +			mdss1_dp0: displayport-controller@22154000 {
> +				compatible = "qcom,sa8775p-dp";
> +
> +				reg = <0x0 0x22154000 0x0 0x104>,

sz = 0x200

> +				      <0x0 0x22154200 0x0 0x0c0>,

sz = 0x200

> +				      <0x0 0x22155000 0x0 0x770>,

sz = 0xc00> +				      <0x0 0x22156000 0x0 0x09c>,
> +				      <0x0 0x22157000 0x0 0x09c>,
> +				      <0x0 0x22158000 0x0 0x09c>,
> +				      <0x0 0x22159000 0x0 0x09c>,

sz = 0x400 for all 0x9c

> +				      <0x0 0x2215a000 0x0 0x23c>,
> +				      <0x0 0x2215b000 0x0 0x23c>;

0x23c -> 0x600

[...]


> +			mdss1_dp1: displayport-controller@2215c000 {
> +				compatible = "qcom,sa8775p-dp";
> +
> +				reg = <0x0 0x2215c000 0x0 0x104>,
> +				      <0x0 0x2215c200 0x0 0x0c0>,
> +				      <0x0 0x2215d000 0x0 0x770>,
> +				      <0x0 0x2215e000 0x0 0x09c>,
> +				      <0x0 0x2215f000 0x0 0x09c>,
> +				      <0x0 0x22160000 0x0 0x09c>,
> +				      <0x0 0x22161000 0x0 0x09c>,
> +				      <0x0 0x22162000 0x0 0x23c>,
> +				      <0x0 0x22163000 0x0 0x23c>;

0x2216_2000 and _3000 don't exist, there's no MST2/3

sizes should be changed similarly 

[...]

>  		dispcc1: clock-controller@22100000 {
> @@ -6872,6 +7115,8 @@ dispcc1: clock-controller@22100000 {
>  				 <&rpmhcc RPMH_CXO_CLK>,
>  				 <&rpmhcc RPMH_CXO_CLK_A>,
>  				 <&sleep_clk>,
> +				 <&mdss1_dp0_phy 0>, <&mdss1_dp0_phy 1>,
> +				 <&mdss1_dp1_phy 0>, <&mdss1_dp1_phy 1>,
>  				 <0>, <0>, <0>, <0>,

You need to remove the same amount of zeroes that you added

Konrad

>  				 <0>, <0>, <0>, <0>;
>  			power-domains = <&rpmhpd SA8775P_MMCX>;

  parent reply	other threads:[~2025-10-08 12:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26  8:59 [PATCH 0/4] Enable mdss1 Display Port for Qualcomm lemans-ride platform Mani Chandana Ballary Kuntumalla
2025-09-26  8:59 ` [PATCH 1/4] drm/msm/dp: Update msm_dp_controller IDs for sa8775p Mani Chandana Ballary Kuntumalla
2025-09-26 11:18   ` Konrad Dybcio
2025-09-26 11:19     ` Konrad Dybcio
2025-09-26 13:51   ` Dmitry Baryshkov
2025-11-20  7:11     ` Mani Chandana Kuntumalla
2025-09-26  8:59 ` [PATCH 2/4] arm64: dts: qcom: lemans: add mdss1 displayPort device nodes Mani Chandana Ballary Kuntumalla
2025-09-26 13:53   ` Dmitry Baryshkov
2025-11-20  7:13     ` Mani Chandana Kuntumalla
2025-10-08 12:40   ` Konrad Dybcio [this message]
2025-10-08 12:49     ` Dmitry Baryshkov
2025-10-08 12:50       ` Konrad Dybcio
2025-10-08 12:57         ` Dmitry Baryshkov
2025-11-20  8:55     ` Mani Chandana Kuntumalla
2025-11-21 16:42       ` Dmitry Baryshkov
2025-09-26  8:59 ` [PATCH 3/4] arm64: dts: qcom: lemans-ride: Enable dispcc1 Mani Chandana Ballary Kuntumalla
2025-09-26 13:53   ` Dmitry Baryshkov
2025-10-01  9:43     ` Konrad Dybcio
2025-10-17 22:54       ` Bjorn Andersson
2025-10-19 11:52         ` Dmitry Baryshkov
2025-11-20  9:01       ` Mani Chandana Kuntumalla
2025-09-26  8:59 ` [PATCH 4/4] arm64: dts: qcom: lemans-ride: Enable mdss1 display Port Mani Chandana Ballary Kuntumalla
2025-10-17 22:51 ` [PATCH 0/4] Enable mdss1 Display Port for Qualcomm lemans-ride platform Bjorn Andersson
2025-11-20  7:08   ` Mani Chandana Kuntumalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3400ab5-c4ea-455a-b8ea-d4fba2ece85d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abel.vesa@linaro.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=alex.vinarskis@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=quic_amitsi@quicnic.com \
    --cc=quic_mkuntuma@quicinc.com \
    --cc=quic_rajeevny@quicinc.com \
    --cc=quic_riteshk@quicnic.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®