* [PATCH] s390/pci: Fix missing pci_dev_put() in zpci_report_status()
@ 2026-08-18 19:17 Niklas Schnelle
2026-08-18 19:52 ` Farhan Ali
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Schnelle @ 2026-08-18 19:17 UTC (permalink / raw)
To: Gerd Bayer, Matthew Rosato, Farhan Ali, Benjamin Block, Julian Ruess
Cc: Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Sven Schnelle,
Ramesh Errabolu, Tobias Schumacher, Halil Pasic,
Peter Oberparleiter, Gerald Schaefer, Christian Borntraeger,
Niklas Schnelle, linux-s390, linux-kernel
In zpci_report_status() a reference to the struct pci_dev associated
with the struct zpci_dev being reported about is acquired using
pci_get_slot(). This reference needs to be dropped with pci_dev_put()
but this call is missing thus leaking the reference. On subsequent hot
unplug this will cause the struct pci_dev to not be released leaking
memory and potentially prevent reattach.
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Fixes: 4ec6054e7321 ("s390/pci: Report PCI error recovery results via SCLP")
Cc: stable@vger.kernel.org
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
---
arch/s390/pci/pci_report.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/pci/pci_report.c b/arch/s390/pci/pci_report.c
index 7030f7052926..76b8afc146fe 100644
--- a/arch/s390/pci/pci_report.c
+++ b/arch/s390/pci/pci_report.c
@@ -151,6 +151,7 @@ int zpci_report_status(struct zpci_dev *zdev, const char *operation, const char
else
pr_info("Reported PCI device status\n");
+ pci_dev_put(pdev);
free_page((unsigned long)report);
return ret;
---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260817-fix_zpci_report_status_pdev_leak-1b101c1fe021
Best regards,
--
Niklas Schnelle
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/pci: Fix missing pci_dev_put() in zpci_report_status()
2026-08-18 19:17 [PATCH] s390/pci: Fix missing pci_dev_put() in zpci_report_status() Niklas Schnelle
@ 2026-08-18 19:52 ` Farhan Ali
0 siblings, 0 replies; 2+ messages in thread
From: Farhan Ali @ 2026-08-18 19:52 UTC (permalink / raw)
To: Niklas Schnelle, Gerd Bayer, Matthew Rosato, Benjamin Block,
Julian Ruess
Cc: Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Sven Schnelle,
Ramesh Errabolu, Tobias Schumacher, Halil Pasic,
Peter Oberparleiter, Gerald Schaefer, Christian Borntraeger,
linux-s390, linux-kernel
On 8/18/2026 12:17 PM, Niklas Schnelle wrote:
> In zpci_report_status() a reference to the struct pci_dev associated
> with the struct zpci_dev being reported about is acquired using
> pci_get_slot(). This reference needs to be dropped with pci_dev_put()
> but this call is missing thus leaking the reference. On subsequent hot
> unplug this will cause the struct pci_dev to not be released leaking
> memory and potentially prevent reattach.
>
> Reviewed-by: Matthew Rosato<mjrosato@linux.ibm.com>
> Fixes: 4ec6054e7321 ("s390/pci: Report PCI error recovery results via SCLP")
> Cc:stable@vger.kernel.org
> Signed-off-by: Niklas Schnelle<schnelle@linux.ibm.com>
> ---
> arch/s390/pci/pci_report.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Farhan Ali<alifm@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-18 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-18 19:17 [PATCH] s390/pci: Fix missing pci_dev_put() in zpci_report_status() Niklas Schnelle
2026-08-18 19:52 ` Farhan Ali
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®