From: Paolo Bonzini <pbonzini@redhat.com>
To: Marc Orr <marcorr@google.com>,
seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, thomas.lendacky@amd.com,
mlevitsk@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Always set kvm_run->if_flag
Date: Thu, 9 Dec 2021 18:48:22 +0100 [thread overview]
Message-ID: <5f8c31b4-6223-a965-0e91-15b4ffc0335e@redhat.com> (raw)
In-Reply-To: <20211209155257.128747-1-marcorr@google.com>
On 12/9/21 16:52, Marc Orr wrote:
> The kvm_run struct's if_flag is a part of the userspace/kernel API. The
> SEV-ES patches failed to set this flag because it's no longer needed by
> QEMU (according to the comment in the source code). However, other
> hypervisors may make use of this flag. Therefore, set the flag for
> guests with encrypted registers (i.e., with guest_state_protected set).
>
> Fixes: f1c6366e3043 ("KVM: SVM: Add required changes to support intercepts under SEV-ES")
> Signed-off-by: Marc Orr<marcorr@google.com>
Applied, though I wonder if it is really needed by those other VMMs
(which? gVisor is the only one that comes to mind that is interested in
userspace APIC).
It shouldn't be necessary for in-kernel APIC (where userspace can inject
interrupts at any time), and ready_for_interrupt_injection is superior
for userspace APIC.
Paolo
next prev parent reply other threads:[~2021-12-09 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:52 Marc Orr
2021-12-09 16:21 ` Maxim Levitsky
2021-12-09 17:48 ` Paolo Bonzini [this message]
2021-12-09 18:20 ` Jim Mattson
2021-12-09 18:22 ` Sean Christopherson
2021-12-09 18:27 ` Jim Mattson
2021-12-09 18:29 ` Marc Orr
2021-12-09 18:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8c31b4-6223-a965-0e91-15b4ffc0335e@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®