From: Paolo Bonzini <pbonzini@redhat.com>
To: Marc Orr <marcorr@google.com>, Sean Christopherson <seanjc@google.com>
Cc: Jim Mattson <jmattson@google.com>,
vkuznets@redhat.com, wanpengli@tencent.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
Thomas.Lendacky@amd.com, mlevitsk@redhat.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Always set kvm_run->if_flag
Date: Thu, 9 Dec 2021 19:55:25 +0100 [thread overview]
Message-ID: <b9d59fee-e1d8-5f96-0b1d-f11c10d8b0f1@redhat.com> (raw)
In-Reply-To: <CAA03e5GE-UGB6YvZfWfWEzpC7+M+EZU3hJsTEOzN0i5UyD5Vpw@mail.gmail.com>
On 12/9/21 19:29, Marc Orr wrote:
> All that being said, after Jim added his Ack to this patch (which I
> forgot to attach to the v2), we realized that technically the ES
> patches were within their right to redefine if_flag since it's
> previous semantics are maintained for non-ES VMs and ES requires
> userspace changes anyway (PSP commands, guest memory pinning, etc.).
Correct, but it's a bit ugly to redefine the semantics and that is why I
am going to apply the patch anyway.
Paolo
> I'm OK either way here. But I assume that if this flag is giving us
> pains it will give others pains. And this patch seems reasonable to
> me. So all things being equal, I'd prefer to proceed with it.
>
prev parent reply other threads:[~2021-12-09 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:52 Marc Orr
2021-12-09 16:21 ` Maxim Levitsky
2021-12-09 17:48 ` Paolo Bonzini
2021-12-09 18:20 ` Jim Mattson
2021-12-09 18:22 ` Sean Christopherson
2021-12-09 18:27 ` Jim Mattson
2021-12-09 18:29 ` Marc Orr
2021-12-09 18:55 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d59fee-e1d8-5f96-0b1d-f11c10d8b0f1@redhat.com \
--to=pbonzini@redhat.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®