mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Nanzhe Zhao <zhaonanzhe@xiaomi.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	Jaegeuk Kim <jaegeuk@kernel.org>, Daeho Jeong <daeho43@gmail.com>,
	Barry Song <baohua@kernel.org>, Juan Yescas <jyescas@google.com>,
	Dev Jain <Dev.Jain@arm.com>,
	linux-kernel@vger.kernel.org,
	David Hildenbrand <David.Hildenbrand@arm.com>,
	Bo Zhang <zhangbo56@xiaomi.com>,
	Kalesh Singh <kaleshsingh@google.com>,
	Nanzhe Zhao <nzzhao@126.com>, Pengfei Li <lipengfei28@xiaomi.com>,
	Ryan Roberts <Ryan.Roberts@arm.com>
Subject: Re: [f2fs-dev] [PATCH v2 04/14] f2fs: support atomic file large folios buffered write
Date: Wed, 23 Sep 2026 15:22:49 +0800	[thread overview]
Message-ID: <5f954f1e-c4b8-4565-a2f2-04d4067293d2@kernel.org> (raw)
In-Reply-To: <20260923032131.2227703-1-zhaonanzhe@xiaomi.com>

On 9/23/26 11:21, Nanzhe Zhao wrote:
> I think I can extract the duplicate logic in a helper and the full change
> may be like this?
Alright, is there a way to relocate below code block before f2fs_balance_fs()?

	if (folio_test_large(folio)) {
		if (f2fs_is_atomic_file(inode))
			err = prepare_large_folio_atomic_write_begin(inode,
					mapping, folio, pos, len);
		else
			err = prepare_large_folio_write_begin(inode,
					folio, pos, len);
		if (!err)
			return 0;
		if (err == -EAGAIN) {
			f2fs_folio_put(folio, true);
			goto repeat;
		}
		goto put_folio;
	}

Thanks,

  reply	other threads:[~2026-09-23  7:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  4:18 [PATCH v2 00/14] f2fs: support & optimize large folios for writable files Nanzhe Zhao
2026-09-15  4:18 ` [PATCH v2 01/14] f2fs: extend folio state for large folio write path Nanzhe Zhao
2026-09-16  9:53   ` Chao Yu
2026-09-15  4:18 ` [PATCH v2 02/14] f2fs: carry subpage offset and count in write IO Nanzhe Zhao
2026-09-15  4:18 ` [PATCH v2 03/14] f2fs: support regular file buffered writes on large folios Nanzhe Zhao
2026-09-16 11:47   ` Chao Yu
2026-09-15  4:18 ` [PATCH v2 04/14] f2fs: support atomic file large folios buffered write Nanzhe Zhao
2026-09-16 12:07   ` Chao Yu
2026-09-23  3:21     ` [f2fs-dev] " Nanzhe Zhao
2026-09-23  7:22       ` Chao Yu [this message]
2026-09-15  4:19 ` [PATCH v2 05/14] f2fs: support large folio writeback Nanzhe Zhao
2026-09-17  3:48   ` Chao Yu
2026-09-21  2:52   ` Chao Yu
2026-09-15  4:19 ` [PATCH v2 06/14] f2fs: prepare mmap write faults for large folios Nanzhe Zhao
2026-09-17  6:32   ` Chao Yu
2026-09-15  4:19 ` [PATCH v2 07/14] f2fs: make GC migration large-folio aware Nanzhe Zhao
2026-09-15  4:19 ` [PATCH v2 08/14] f2fs: optimize small block size large folio read Nanzhe Zhao
2026-09-16  4:33   ` [f2fs-dev] " Daeho Jeong
2026-09-23  2:36     ` Nanzhe Zhao
2026-09-24  1:34     ` Nanzhe Zhao
2026-09-17  8:09   ` Chao Yu
2026-09-15  4:19 ` [PATCH v2 09/14] f2fs: support partial uptodate " Nanzhe Zhao
2026-09-15  4:19 ` [PATCH v2 10/14] f2fs: handle partial truncate of large folio dirty subpages Nanzhe Zhao
2026-09-17  8:30   ` Chao Yu
2026-09-23  2:50     ` [f2fs-dev] " Nanzhe Zhao
2026-09-23  7:18       ` Chao Yu
2026-09-17  8:32   ` Chao Yu
2026-09-15  4:25 ` [PATCH v2 11/14] f2fs: fix zeroing paths for large folios Nanzhe Zhao
2026-09-15  4:25 ` [PATCH v2 12/14] f2fs: handle block cloning within the same large folio Nanzhe Zhao
2026-09-15  4:25 ` [PATCH v2 13/14] f2fs: allow large folio support to writeable files Nanzhe Zhao
2026-09-17 14:07   ` Chao Yu
2026-09-15  4:25 ` [PATCH v2 14/14] f2fs: make compressed files compatible with large folio Nanzhe Zhao
2026-09-22  3:09   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f954f1e-c4b8-4565-a2f2-04d4067293d2@kernel.org \
    --to=chao@kernel.org \
    --cc=David.Hildenbrand@arm.com \
    --cc=Dev.Jain@arm.com \
    --cc=Ryan.Roberts@arm.com \
    --cc=baohua@kernel.org \
    --cc=daeho43@gmail.com \
    --cc=jaegeuk@kernel.org \
    --cc=jyescas@google.com \
    --cc=kaleshsingh@google.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipengfei28@xiaomi.com \
    --cc=nzzhao@126.com \
    --cc=zhangbo56@xiaomi.com \
    --cc=zhaonanzhe@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®