From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: Fabian Frederick <fabf@skynet.be>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()
Date: Tue, 31 Jan 2017 12:28:34 +0100 [thread overview]
Message-ID: <5faaa712-63d3-7462-ad58-39a22ead8e0a@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170130184723.18186-1-fabf@skynet.be>
ACK - compile-tested successfully on s390.
On 01/30/2017 07:47 PM, Fabian Frederick wrote:
> instead of atomic_add_unless(value, -1, 0)
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/s390/net/qeth_core_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 315d8a2..9595b90 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3278,7 +3278,7 @@ void qeth_queue_input_buffer(struct qeth_card *card, int index)
> atomic_set(&card->force_alloc_skb, 3);
> count = newcount;
> } else {
> - atomic_add_unless(&card->force_alloc_skb, -1, 0);
> + atomic_dec_not_zero(&card->force_alloc_skb);
> }
>
> if (!count) {
>
prev parent reply other threads:[~2017-01-31 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 18:47 Fabian Frederick
2017-01-31 11:28 ` Ursula Braun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5faaa712-63d3-7462-ad58-39a22ead8e0a@linux.vnet.ibm.com \
--to=ubraun@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®