* [PATCH] drm/v3d: Use v3d_perfmon_find(..)
@ 2024-09-23 15:19 Christian Gmeiner
2024-09-24 23:27 ` Maíra Canal
0 siblings, 1 reply; 2+ messages in thread
From: Christian Gmeiner @ 2024-09-23 15:19 UTC (permalink / raw)
To: Melissa Wen, Maíra Canal, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Christian Gmeiner, dri-devel, linux-kernel
From: Christian Gmeiner <cgmeiner@igalia.com>
Replace the open coded v3d_perfmon_find(..) with the real
thing.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
---
drivers/gpu/drm/v3d/v3d_perfmon.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
index cd7f1eedf17f..54a486a9b74c 100644
--- a/drivers/gpu/drm/v3d/v3d_perfmon.c
+++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
@@ -402,11 +402,7 @@ int v3d_perfmon_get_values_ioctl(struct drm_device *dev, void *data,
if (req->pad != 0)
return -EINVAL;
- mutex_lock(&v3d_priv->perfmon.lock);
- perfmon = idr_find(&v3d_priv->perfmon.idr, req->id);
- v3d_perfmon_get(perfmon);
- mutex_unlock(&v3d_priv->perfmon.lock);
-
+ perfmon = v3d_perfmon_find(v3d_priv, req->id);
if (!perfmon)
return -EINVAL;
--
2.46.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/v3d: Use v3d_perfmon_find(..)
2024-09-23 15:19 [PATCH] drm/v3d: Use v3d_perfmon_find(..) Christian Gmeiner
@ 2024-09-24 23:27 ` Maíra Canal
0 siblings, 0 replies; 2+ messages in thread
From: Maíra Canal @ 2024-09-24 23:27 UTC (permalink / raw)
To: Christian Gmeiner, Melissa Wen, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Christian Gmeiner, dri-devel, linux-kernel
Hi Christian,
On 9/23/24 12:19, Christian Gmeiner wrote:
> From: Christian Gmeiner <cgmeiner@igalia.com>
>
> Replace the open coded v3d_perfmon_find(..) with the real
> thing.
>
> Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Thanks for your patch!
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Applied to misc/kernel.git (drm-misc-next).
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/v3d/v3d_perfmon.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
> index cd7f1eedf17f..54a486a9b74c 100644
> --- a/drivers/gpu/drm/v3d/v3d_perfmon.c
> +++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
> @@ -402,11 +402,7 @@ int v3d_perfmon_get_values_ioctl(struct drm_device *dev, void *data,
> if (req->pad != 0)
> return -EINVAL;
>
> - mutex_lock(&v3d_priv->perfmon.lock);
> - perfmon = idr_find(&v3d_priv->perfmon.idr, req->id);
> - v3d_perfmon_get(perfmon);
> - mutex_unlock(&v3d_priv->perfmon.lock);
> -
> + perfmon = v3d_perfmon_find(v3d_priv, req->id);
> if (!perfmon)
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-24 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-23 15:19 [PATCH] drm/v3d: Use v3d_perfmon_find(..) Christian Gmeiner
2024-09-24 23:27 ` Maíra Canal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®