mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Matt Fleming" <mattjfleming@googlemail.com>
To: "Pierre Ossman" <drzeus-mmc@drzeus.cx>
Cc: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net
Subject: Re: [RFC][PATCH] MMC: Use write timeout value as read from CSR
Date: Tue, 9 Sep 2008 08:59:11 +0100	[thread overview]
Message-ID: <5ff4a1e50809090059i2bcdb7ber8cae07128eea5a77@mail.gmail.com> (raw)
In-Reply-To: <20080909094438.6423b8ef@mjolnir.drzeus.cx>

2008/9/9 Pierre Ossman <drzeus-mmc@drzeus.cx>:
> On Tue, 9 Sep 2008 08:34:27 +0100
> "Matt Fleming" <mattjfleming@googlemail.com> wrote:
>
>> 2008/9/9 Pierre Ossman <drzeus-mmc@drzeus.cx>:
>> > On Mon, 8 Sep 2008 14:28:00 +0100
>> > "Matt Fleming" <mattjfleming@googlemail.com> wrote:
>> >
>> >> You're right, I changed the patch accordingly (I also fixed the read
>> >> timeout path).
>> >>
>> >
>> > This still doesn't use the fields from the request structure. E.g. SDIO
>> > support is probably still broken here as it mandates a timeout of 1
>> > second for data transfers.
>> >
>>
>> What fields in the request structure? Are you talking about struct mmc_request ?
>
> Yup, timeout_ns and timeout_clks.
>

OK, just to be clear, where are those fields not used? They are used
in the new mmc_get_timeout() function.

I'm assuming SDIO should use the same logic as MMC for working out the
timeout value? Or is there an upper limit of 1 second on the timeout
for SDIO? I am not very confident in my understanding of the nuances
of SDIO. Also, I don't have any SDIO hardware so I can't test this
change (which is the reason I didn't change it in the first place).

  reply	other threads:[~2008-09-09  7:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 15:12 Matt Fleming
2008-09-07 10:38 ` Pierre Ossman
2008-09-08 13:28   ` Matt Fleming
2008-09-08 19:18     ` David Brownell
2008-09-09  7:22     ` Pierre Ossman
2008-09-09  7:34       ` Matt Fleming
2008-09-09  7:44         ` Pierre Ossman
2008-09-09  7:59           ` Matt Fleming [this message]
2008-09-09  8:55             ` Pierre Ossman
2008-09-09  9:07               ` Matt Fleming
2008-09-09  9:42                 ` Matt Fleming
2008-09-14 13:48                   ` Pierre Ossman
     [not found]                     ` <5ff4a1e50809150103v1e250e0x4192e2fe901750a6@mail.gmail.com>
     [not found]                       ` <20080915103821.2b618bba@mjolnir.drzeus.cx>
2008-09-15  9:24                         ` Matt Fleming
2008-09-20 11:06                           ` Pierre Ossman
2008-09-24 11:16                             ` Matt Fleming
2008-10-02  8:26                               ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ff4a1e50809090059i2bcdb7ber8cae07128eea5a77@mail.gmail.com \
    --to=mattjfleming@googlemail.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®