From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Kenneth Lee <klee33@uw.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element
Date: Wed, 17 Aug 2022 13:24:51 +0100 [thread overview]
Message-ID: <601d9f11-254b-ece9-df61-e6a352f520d0@linaro.org> (raw)
In-Reply-To: <20220810031037.2620221-1-klee33@uw.edu>
On 10/08/2022 04:10, Kenneth Lee wrote:
> Use kzalloc(...) rather than kcalloc(1, ...) because the number of
> elements we are specifying in this case is 1, so kzalloc would
> accomplish the same thing and we can simplify.
>
> Signed-off-by: Kenneth Lee <klee33@uw.edu>
> ---
Applied thanks,
--srini
> drivers/nvmem/brcm_nvram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
> index 450b927691c3..4441daa20965 100644
> --- a/drivers/nvmem/brcm_nvram.c
> +++ b/drivers/nvmem/brcm_nvram.c
> @@ -96,7 +96,7 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
>
> len = le32_to_cpu(header.len);
>
> - data = kcalloc(1, len, GFP_KERNEL);
> + data = kzalloc(len, GFP_KERNEL);
> memcpy_fromio(data, priv->base, len);
> data[len - 1] = '\0';
>
prev parent reply other threads:[~2022-08-17 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 3:10 Kenneth Lee
2022-08-17 12:24 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601d9f11-254b-ece9-df61-e6a352f520d0@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=klee33@uw.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®