* [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element
@ 2022-08-10 3:10 Kenneth Lee
2022-08-17 12:24 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Kenneth Lee @ 2022-08-10 3:10 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: linux-kernel, Kenneth Lee
Use kzalloc(...) rather than kcalloc(1, ...) because the number of
elements we are specifying in this case is 1, so kzalloc would
accomplish the same thing and we can simplify.
Signed-off-by: Kenneth Lee <klee33@uw.edu>
---
drivers/nvmem/brcm_nvram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
index 450b927691c3..4441daa20965 100644
--- a/drivers/nvmem/brcm_nvram.c
+++ b/drivers/nvmem/brcm_nvram.c
@@ -96,7 +96,7 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
len = le32_to_cpu(header.len);
- data = kcalloc(1, len, GFP_KERNEL);
+ data = kzalloc(len, GFP_KERNEL);
memcpy_fromio(data, priv->base, len);
data[len - 1] = '\0';
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element
2022-08-10 3:10 [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element Kenneth Lee
@ 2022-08-17 12:24 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2022-08-17 12:24 UTC (permalink / raw)
To: Kenneth Lee; +Cc: linux-kernel
On 10/08/2022 04:10, Kenneth Lee wrote:
> Use kzalloc(...) rather than kcalloc(1, ...) because the number of
> elements we are specifying in this case is 1, so kzalloc would
> accomplish the same thing and we can simplify.
>
> Signed-off-by: Kenneth Lee <klee33@uw.edu>
> ---
Applied thanks,
--srini
> drivers/nvmem/brcm_nvram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
> index 450b927691c3..4441daa20965 100644
> --- a/drivers/nvmem/brcm_nvram.c
> +++ b/drivers/nvmem/brcm_nvram.c
> @@ -96,7 +96,7 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
>
> len = le32_to_cpu(header.len);
>
> - data = kcalloc(1, len, GFP_KERNEL);
> + data = kzalloc(len, GFP_KERNEL);
> memcpy_fromio(data, priv->base, len);
> data[len - 1] = '\0';
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-17 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-10 3:10 [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element Kenneth Lee
2022-08-17 12:24 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®