[GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[Rafael J. Wysocki]

Hi Linus,

Please pull from the tag

 git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
 acpi-7.2-rc1-2

with top-most commit cf1e70d021343d33728e54a6227607925c8d5419

 Merge branches 'acpi-sysfs', 'acpi-resource', 'acpi-driver' and
'acpi-processor'

on top of commit eed451031f6ac098ca04ebdd63d34e083ba2d6f6

 Merge tag 'acpi-7.2-rc1' of
gitolite.kernel.org:pub/scm/linux/kernel/git/rafael/linux-pm

to receive fixes and cleanups related to ACPI support for 7.2-rc1.

These fix assorted issues and do cleanups in the ACPI support code,
which includes a fix for tools build breakage related to strncpy()
removal:

 - Unbreak ACPICA tools builds after switching over to using
   strscpy_pad() that is kernel-specific (Rafael Wysocki)

 - Fix module parameter file paths in comments in the ACPI code managing
   the general sysfs attributes (Zenghui Yu)

 - Update kerneldoc comments in the ACPI resource management code to
   follow the common style (Andy Shevchenko)

 - Fix inverted interface check in ipmi_bmc_gone() that may cause ACPI
   IPMI interfaces to be mishandled (Xu Rao)

 - Add __cpuidle annotation to idle state management functions related
   to ACPI _LPI to avoid trace-induced RCU warnings (Li RongQing)

Thanks!


---------------

Andy Shevchenko (1):
      ACPI: resource: Amend kernel-doc style

Li RongQing (1):
      ACPI: processor_idle: Mark LPI enter functions as __cpuidle

Rafael J. Wysocki (1):
      ACPICA: Unbreak tools build after switching over to strscpy_pad()

Xu Rao (1):
      ACPI: IPMI: Fix inverted interface check in ipmi_bmc_gone()

Zenghui Yu (1):
      ACPI: sysfs: Fix path of module parameters in comments

---------------

 drivers/acpi/acpi_ipmi.c        |  2 +-
 drivers/acpi/acpica/utnonansi.c |  9 +++++++++
 drivers/acpi/processor_idle.c   |  4 ++--
 drivers/acpi/resource.c         |  6 +++---
 drivers/acpi/riscv/cpuidle.c    |  2 +-
 drivers/acpi/sysfs.c            | 14 +++++++-------
 6 files changed, 23 insertions(+), 14 deletions(-)

Re: [GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[Linus Torvalds]

On Fri, 26 Jun 2026 at 10:54, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
>  - Unbreak ACPICA tools builds after switching over to using
>    strscpy_pad() that is kernel-specific (Rafael Wysocki)

Ugh, honestly, this is disgusting.

I've pulled this, but this file is not in some kind of "tools"
directory, so the fact that it then also gets compiled in user space
should be treated as a user space problem.

I had to really scratch my head how it's even build by user space at
all, and it's due to absolutely disgusting code in

    tools/power/acpi/tools/acpidump/Makefile

that uses a vpath thing to find that C file for that tool build.

That's just crazy.

But the fix is *still* not to add horrendous "let's use strncpy() when
not built for the kernel" in code that looks and acts like kernel
code. None of the other acpica code does that.

How about just adding a trivial strncpy_pad() to
<acpi/platform/acenv.h> or something. A place that already knows about
the whole "I'm building the app side" now.

Hmm?

             Linus

Re: [GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[Linus Torvalds]

On Fri, 26 Jun 2026 at 13:13, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> How about just adding a trivial strncpy_pad() to
> <acpi/platform/acenv.h> or something. A place that already knows about
> the whole "I'm building the app side" now.

Actually, isn't this what tools/power/acpi/common/ are supposed to deal with?

IOW, maybe just add a "strncpy_pad()" implementation there?

(I'm not very cognizant of how this build is supposed to be done, soo..)

            Linus

Re: [GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[Rafael J. Wysocki (Intel)]

On Fri, Jun 26, 2026 at 10:14 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Fri, 26 Jun 2026 at 10:54, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> >  - Unbreak ACPICA tools builds after switching over to using
> >    strscpy_pad() that is kernel-specific (Rafael Wysocki)
>
> Ugh, honestly, this is disgusting.
>
> I've pulled this,

Thanks!

> but this file is not in some kind of "tools"
> directory, so the fact that it then also gets compiled in user space
> should be treated as a user space problem.
>
> I had to really scratch my head how it's even build by user space at
> all, and it's due to absolutely disgusting code in
>
>     tools/power/acpi/tools/acpidump/Makefile
>
> that uses a vpath thing to find that C file for that tool build.
>
> That's just crazy.

I don't dispute your judgement.

The background though is that the code is shared between the kernel
and the tools because the output of those tools needs to match exactly
what is seen and used by the kernel.  Otherwise it might not make much
sense to use them.

> But the fix is *still* not to add horrendous "let's use strncpy() when
> not built for the kernel" in code that looks and acts like kernel
> code. None of the other acpica code does that.

No, it doesn't and the change in question is more of a stop-gap than
something I'd like to be there in the long term.

> How about just adding a trivial strncpy_pad() to
> <acpi/platform/acenv.h> or something. A place that already knows about
> the whole "I'm building the app side" now.
>
> Hmm?

Something like that or define acpi_ut_safe_strncpy() as an alias for
strncpy_pad() when that's available.

I'll figure this out.

Re: [GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[Rafael J. Wysocki]

On Monday, June 29, 2026 2:22:51 PM CEST Rafael J. Wysocki (Intel) wrote:
> On Fri, Jun 26, 2026 at 10:14 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Fri, 26 Jun 2026 at 10:54, Rafael J. Wysocki <rafael@kernel.org> wrote:
> > 
> > How about just adding a trivial strncpy_pad() to
> > <acpi/platform/acenv.h> or something. A place that already knows about
> > the whole "I'm building the app side" now.
> >
> > Hmm?
> 
> Something like that or define acpi_ut_safe_strncpy() as an alias for
> strncpy_pad() when that's available.
> 
> I'll figure this out.

So this can be done (on top of 7.2-rc1) and I prefer it to the current
code, so please let me know what you think:

---
 drivers/acpi/acpica/acutils.h     |    2 ++
 drivers/acpi/acpica/utnonansi.c   |   10 ++--------
 include/acpi/platform/aclinuxex.h |    1 +
 3 files changed, 5 insertions(+), 8 deletions(-)

--- a/drivers/acpi/acpica/acutils.h
+++ b/drivers/acpi/acpica/acutils.h
@@ -626,7 +626,9 @@ void acpi_ut_repair_name(char *name);
 #if defined (ACPI_DEBUGGER) || defined (ACPI_APPLICATION) || defined (ACPI_DEBUG_OUTPUT)
 u8 acpi_ut_safe_strcpy(char *dest, acpi_size dest_size, char *source);
 
+#if !defined (acpi_ut_safe_strncpy)
 void acpi_ut_safe_strncpy(char *dest, char *source, acpi_size dest_size);
+#endif
 
 u8 acpi_ut_safe_strcat(char *dest, acpi_size dest_size, char *source);
 
--- a/drivers/acpi/acpica/utnonansi.c
+++ b/drivers/acpi/acpica/utnonansi.c
@@ -164,20 +164,14 @@ acpi_ut_safe_strncat(char *dest,
 	return (FALSE);
 }
 
+#if !defined (acpi_ut_safe_strncpy)
 void acpi_ut_safe_strncpy(char *dest, char *source, acpi_size dest_size)
 {
 	/* Always terminate destination string */
 
-#ifdef __KERNEL__
-	strscpy_pad(dest, source, dest_size);
-#else
-	/*
-	 * strscpy_pad() is not defined in ACPICA tools builds, so use strncpy()
-	 * and directly NUL-terminate the destination string in that case.
-	 */
 	strncpy(dest, source, dest_size);
 	dest[dest_size - 1] = 0;
-#endif
 }
+#endif
 
 #endif
--- a/include/acpi/platform/aclinuxex.h
+++ b/include/acpi/platform/aclinuxex.h
@@ -134,6 +134,7 @@ static inline void acpi_os_terminate_deb
 /*
  * OSL interfaces added by Linux
  */
+#define acpi_ut_safe_strncpy	strscpy_pad
 
 #endif				/* __KERNEL__ */
 

Re: [GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[Rafael J. Wysocki]

On Monday, June 29, 2026 3:15:12 PM CEST Rafael J. Wysocki wrote:
> On Monday, June 29, 2026 2:22:51 PM CEST Rafael J. Wysocki (Intel) wrote:
> > On Fri, Jun 26, 2026 at 10:14 PM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > On Fri, 26 Jun 2026 at 10:54, Rafael J. Wysocki <rafael@kernel.org> wrote:
> > > 
> > > How about just adding a trivial strncpy_pad() to
> > > <acpi/platform/acenv.h> or something. A place that already knows about
> > > the whole "I'm building the app side" now.
> > >
> > > Hmm?
> > 
> > Something like that or define acpi_ut_safe_strncpy() as an alias for
> > strncpy_pad() when that's available.
> > 
> > I'll figure this out.

Interestingly enough, the ACPICA tools don't even call acpi_ut_safe_strncpy(),
so if it is defined as an strncpy_pad() alias, the original definition of it
can be dropped entirely.

I'm going to make this change.

Re: [GIT PULL] ACPI support fixes and cleanups for 7.2-rc1

[pr-tracker-bot]

The pull request you sent on Fri, 26 Jun 2026 19:54:06 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git acpi-7.2-rc1-2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/737b9ff0c816f7d2eac91897e44e89984939662c

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html