* [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS
@ 2023-02-09 16:19 Carlos Bilbao
2023-02-09 17:04 ` Carlos Bilbao
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Carlos Bilbao @ 2023-02-09 16:19 UTC (permalink / raw)
To: richard, anton.ivanov, johannes; +Cc: linux-um, linux-kernel, Carlos Bilbao
Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
operand for bit shift.
Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
---
arch/um/drivers/vector_user.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/drivers/vector_user.h b/arch/um/drivers/vector_user.h
index 3a73d17a0161..f7d3956f5c15 100644
--- a/arch/um/drivers/vector_user.h
+++ b/arch/um/drivers/vector_user.h
@@ -68,8 +68,8 @@ struct vector_fds {
};
#define VECTOR_READ 1
-#define VECTOR_WRITE (1 < 1)
-#define VECTOR_HEADERS (1 < 2)
+#define VECTOR_WRITE (1 << 1)
+#define VECTOR_HEADERS (1 << 2)
extern struct arglist *uml_parse_vector_ifspec(char *arg);
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS
2023-02-09 16:19 [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS Carlos Bilbao
@ 2023-02-09 17:04 ` Carlos Bilbao
2023-02-09 17:12 ` Anton Ivanov
2023-02-09 17:33 ` Anton Ivanov
2 siblings, 0 replies; 5+ messages in thread
From: Carlos Bilbao @ 2023-02-09 17:04 UTC (permalink / raw)
To: richard, anton.ivanov, johannes; +Cc: linux-um, linux-kernel
Just noticed commit typo, if you could please fix, s/definitios/definitions
On 2/9/23 10:19, Carlos Bilbao wrote:
> Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
> operand for bit shift.
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
> arch/um/drivers/vector_user.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/um/drivers/vector_user.h b/arch/um/drivers/vector_user.h
> index 3a73d17a0161..f7d3956f5c15 100644
> --- a/arch/um/drivers/vector_user.h
> +++ b/arch/um/drivers/vector_user.h
> @@ -68,8 +68,8 @@ struct vector_fds {
> };
>
> #define VECTOR_READ 1
> -#define VECTOR_WRITE (1 < 1)
> -#define VECTOR_HEADERS (1 < 2)
> +#define VECTOR_WRITE (1 << 1)
> +#define VECTOR_HEADERS (1 << 2)
>
> extern struct arglist *uml_parse_vector_ifspec(char *arg);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS
2023-02-09 16:19 [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS Carlos Bilbao
2023-02-09 17:04 ` Carlos Bilbao
@ 2023-02-09 17:12 ` Anton Ivanov
2023-02-09 17:33 ` Anton Ivanov
2 siblings, 0 replies; 5+ messages in thread
From: Anton Ivanov @ 2023-02-09 17:12 UTC (permalink / raw)
To: Carlos Bilbao, richard, johannes; +Cc: linux-um, linux-kernel
On 09/02/2023 16:19, Carlos Bilbao wrote:
> Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
> operand for bit shift.
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
> arch/um/drivers/vector_user.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/um/drivers/vector_user.h b/arch/um/drivers/vector_user.h
> index 3a73d17a0161..f7d3956f5c15 100644
> --- a/arch/um/drivers/vector_user.h
> +++ b/arch/um/drivers/vector_user.h
> @@ -68,8 +68,8 @@ struct vector_fds {
> };
>
> #define VECTOR_READ 1
> -#define VECTOR_WRITE (1 < 1)
> -#define VECTOR_HEADERS (1 < 2)
> +#define VECTOR_WRITE (1 << 1)
> +#define VECTOR_HEADERS (1 << 2)
>
> extern struct arglist *uml_parse_vector_ifspec(char *arg);
>
I need to have a look at the code how it even worked before. Will ack
after that.
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS
2023-02-09 16:19 [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS Carlos Bilbao
2023-02-09 17:04 ` Carlos Bilbao
2023-02-09 17:12 ` Anton Ivanov
@ 2023-02-09 17:33 ` Anton Ivanov
2023-02-09 18:14 ` Carlos Bilbao
2 siblings, 1 reply; 5+ messages in thread
From: Anton Ivanov @ 2023-02-09 17:33 UTC (permalink / raw)
To: Carlos Bilbao, richard, johannes; +Cc: linux-um, linux-kernel
On 09/02/2023 16:19, Carlos Bilbao wrote:
> Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
> operand for bit shift.
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
> arch/um/drivers/vector_user.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/um/drivers/vector_user.h b/arch/um/drivers/vector_user.h
> index 3a73d17a0161..f7d3956f5c15 100644
> --- a/arch/um/drivers/vector_user.h
> +++ b/arch/um/drivers/vector_user.h
> @@ -68,8 +68,8 @@ struct vector_fds {
> };
>
> #define VECTOR_READ 1
> -#define VECTOR_WRITE (1 < 1)
> -#define VECTOR_HEADERS (1 < 2)
> +#define VECTOR_WRITE (1 << 1)
> +#define VECTOR_HEADERS (1 << 2)
>
> extern struct arglist *uml_parse_vector_ifspec(char *arg);
>
These are no longer used. They were used in some very early versions of
the code.
They should just be removed instead of redefined correctly.
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS
2023-02-09 17:33 ` Anton Ivanov
@ 2023-02-09 18:14 ` Carlos Bilbao
0 siblings, 0 replies; 5+ messages in thread
From: Carlos Bilbao @ 2023-02-09 18:14 UTC (permalink / raw)
To: Anton Ivanov, richard, johannes; +Cc: linux-um, linux-kernel
On 2/9/23 11:33, Anton Ivanov wrote:
> On 09/02/2023 16:19, Carlos Bilbao wrote:
>> Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
>> operand for bit shift.
>>
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
>> ---
>> arch/um/drivers/vector_user.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/um/drivers/vector_user.h
>> b/arch/um/drivers/vector_user.h
>> index 3a73d17a0161..f7d3956f5c15 100644
>> --- a/arch/um/drivers/vector_user.h
>> +++ b/arch/um/drivers/vector_user.h
>> @@ -68,8 +68,8 @@ struct vector_fds {
>> };
>> #define VECTOR_READ 1
>> -#define VECTOR_WRITE (1 < 1)
>> -#define VECTOR_HEADERS (1 < 2)
>> +#define VECTOR_WRITE (1 << 1)
>> +#define VECTOR_HEADERS (1 << 2)
>> extern struct arglist *uml_parse_vector_ifspec(char *arg);
>
> These are no longer used. They were used in some very early versions
> of the code.
>
> They should just be removed instead of redefined correctly.
>
Ack, sending patch your way.
Thanks,
Carlos
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-09 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 16:19 [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS Carlos Bilbao
2023-02-09 17:04 ` Carlos Bilbao
2023-02-09 17:12 ` Anton Ivanov
2023-02-09 17:33 ` Anton Ivanov
2023-02-09 18:14 ` Carlos Bilbao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®