* Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages
@ 2020-07-20 11:31 Markus Elfring
2020-07-20 12:38 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2020-07-20 11:31 UTC (permalink / raw)
To: Chao Yu, linux-f2fs-devel; +Cc: linux-kernel, Jaegeuk Kim
> Memory allocated for storing compressed pages' poitner should be
> released after f2fs_write_compressed_pages(), otherwise it will
> cause memory leak issue.
* Would an imperative wording be more appropriate (without a typo)
for the change description?
* Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages
2020-07-20 11:31 [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages Markus Elfring
@ 2020-07-20 12:38 ` Chao Yu
2020-07-20 12:49 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2020-07-20 12:38 UTC (permalink / raw)
To: Markus Elfring, linux-f2fs-devel; +Cc: linux-kernel, Jaegeuk Kim
On 2020/7/20 19:31, Markus Elfring wrote:
>> Memory allocated for storing compressed pages' poitner should be
>> released after f2fs_write_compressed_pages(), otherwise it will
>> cause memory leak issue.
>
> * Would an imperative wording be more appropriate (without a typo)
> for the change description?
>
> * Will the tag “Fixes” become helpful for the commit message?
It looks this is replied from patch-robot? since I found all comments
you replied are almost the same.
And what's funny is that the reply starts being caught by another patch-bot
from Greg...
https://lkml.org/lkml/2020/6/28/157
>
> Regards,
> Markus
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages
2020-07-20 12:38 ` Chao Yu
@ 2020-07-20 12:49 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-07-20 12:49 UTC (permalink / raw)
To: Chao Yu, linux-f2fs-devel; +Cc: linux-kernel, Jaegeuk Kim
>>> Memory allocated for storing compressed pages' poitner should be
>>> released after f2fs_write_compressed_pages(), otherwise it will
>>> cause memory leak issue.
>>
>> * Would an imperative wording be more appropriate (without a typo)
>> for the change description?
>>
>> * Will the tag “Fixes” become helpful for the commit message?
>
> It looks this is replied from patch-robot? since I found all comments
> you replied are almost the same.
I dare to repeat such suggestions because several patches contain
improvable details (not only in the affected source code).
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-20 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 11:31 [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages Markus Elfring
2020-07-20 12:38 ` Chao Yu
2020-07-20 12:49 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome