mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Kunwu Chan <kunwu.chan@linux.dev>, igor.b@beldev.am
Cc: namcao@linutronix.de, Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Conor Dooley <conor@kernel.org>, Alexandre Ghiti <alex@ghiti.fr>,
	 Anup Patel <anup@brainfault.org>,
	Atish Patra <atishp@rivosinc.com>,  Zong Li <zong.li@sifive.com>,
	Deepak Gupta <debug@rivosinc.com>,
	 Zhouyi Zhou <zhouzhouyi@gmail.com>,
	linux-riscv@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code
Date: Tue, 17 Feb 2026 14:12:36 -0700 (MST)	[thread overview]
Message-ID: <609b889a-8bb1-d2b5-8de6-ddeec27cac04@kernel.org> (raw)
In-Reply-To: <20260214023804.677127-1-kunwu.chan@linux.dev>

On Sat, 14 Feb 2026, Kunwu Chan wrote:

> Fix a few minor issues found in riscv XIP-related code:
> 
> - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> - head.S: spelling typo and wrong #endif comment

Thanks for fixing the threading, but, Conor's message:

  https://lore.kernel.org/linux-riscv/20260213-canteen-diffuser-5ecc80f264b4@spud/   

was exactly right.  Folks who care about XIP support for RISC-V first need 
to send patches to fix it in mainline.  These typo fixes should be rolled 
in to that series.  Until that happens, I plan to keep the XIP removal 
patches queued.

I also want to see the XIP folks participating in testing and reviewing 
upstream patches going forward to confirm that they don't break XIP 
support.  Otherwise, the burden is just getting pushed to patch submitters 
and maintainers, most of whom probably don't care much about XIP.  And 
there's a good chance that we'll just go through this cycle again in 
another few months.


- Paul



  parent reply	other threads:[~2026-02-17 21:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  2:38 Kunwu Chan
2026-02-14  2:38 ` [PATCH RESEND 1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue Kunwu Chan
2026-02-14  2:38 ` [PATCH RESEND 2/2] riscv: head.S: fix typo and wrong #endif comment Kunwu Chan
2026-02-17 21:12 ` Paul Walmsley [this message]
2026-02-18  0:58   ` [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code Nam Cao
2026-02-20 15:38 ` Jisheng Zhang
2026-02-20 22:39   ` Conor Dooley
2026-03-18 23:23 ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=609b889a-8bb1-d2b5-8de6-ddeec27cac04@kernel.org \
    --to=pjw@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@rivosinc.com \
    --cc=conor@kernel.org \
    --cc=debug@rivosinc.com \
    --cc=igor.b@beldev.am \
    --cc=kunwu.chan@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=namcao@linutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=zhouzhouyi@gmail.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome