From: Conor Dooley <conor@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Kunwu Chan <kunwu.chan@linux.dev>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@rivosinc.com>, Zong Li <zong.li@sifive.com>,
Deepak Gupta <debug@rivosinc.com>,
Zhouyi Zhou <zhouzhouyi@gmail.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code
Date: Fri, 20 Feb 2026 22:39:01 +0000 [thread overview]
Message-ID: <20260220-cardigan-scanning-da6647279ea8@spud> (raw)
In-Reply-To: <aZh_25dtac8wDFNe@xhacker>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Fri, Feb 20, 2026 at 11:38:03PM +0800, Jisheng Zhang wrote:
> On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote:
> > Fix a few minor issues found in riscv XIP-related code:
>
> 'RESEND' isn't expected to be used as you did in this series.
> You sent the v1 series on Feb 14, only 4 days ago, the series doesn't
> miss any dev window.
> https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@linux.dev/T/#t
v1 wasn't threaded correctly, so I think a resend is fine as the content
didn't change.
> > - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> > - head.S: spelling typo and wrong #endif comment
>
> I'm sorry, but how important is fixing comment/spelling typo or #endif
> comment among maintainship?
It's not, but I think we've made this point already!
> The riscv XIP code doesn't stand on itself,
> but heavily affects and is affected by other riscv arch common code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-02-20 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 2:38 Kunwu Chan
2026-02-14 2:38 ` [PATCH RESEND 1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue Kunwu Chan
2026-02-14 2:38 ` [PATCH RESEND 2/2] riscv: head.S: fix typo and wrong #endif comment Kunwu Chan
2026-02-17 21:12 ` [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code Paul Walmsley
2026-02-18 0:58 ` Nam Cao
2026-02-20 15:38 ` Jisheng Zhang
2026-02-20 22:39 ` Conor Dooley [this message]
2026-03-18 23:23 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220-cardigan-scanning-da6647279ea8@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=debug@rivosinc.com \
--cc=jszhang@kernel.org \
--cc=kunwu.chan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=zhouzhouyi@gmail.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®