mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Umang Jain <umang.jain@ideasonboard.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org
Cc: "Paul J. Murphy" <paul.j.murphy@intel.com>,
	Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] media: i2c: imx335: Fix hblank min/max values
Date: Tue, 10 Oct 2023 09:45:51 +0530	[thread overview]
Message-ID: <60a729ac-541a-6e92-34f4-411f78d010ec@ideasonboard.com> (raw)
In-Reply-To: <20231010005126.3425444-5-kieran.bingham@ideasonboard.com>

Hi Kieran

On 10/10/23 6:21 AM, Kieran Bingham wrote:
> The V4L2_CID_HBLANK control is marked as readonly and can only be a
> single value.
>
> Set the minimum and maximum value to match the mode value.
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   drivers/media/i2c/imx335.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 026777eb362e..1a34b2a43718 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -1043,8 +1043,8 @@ static int imx335_init_controls(struct imx335 *imx335)
>   	imx335->hblank_ctrl = v4l2_ctrl_new_std(ctrl_hdlr,
>   						&imx335_ctrl_ops,
>   						V4L2_CID_HBLANK,
> -						IMX335_REG_MIN,
> -						IMX335_REG_MAX,
> +						mode->hblank,
> +						mode->hblank,
>   						1, mode->hblank);
>   	if (imx335->hblank_ctrl)
>   		imx335->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;


  reply	other threads:[~2023-10-10  4:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231010005126.3425444-1-kieran.bingham@ideasonboard.com>
2023-10-10  0:51 ` [PATCH 1/5] media: dt-bindings: media: imx335: Add supply bindings Kieran Bingham
2023-10-10  3:53   ` Umang Jain
2023-10-10  5:03   ` Marco Felsch
2023-10-10  6:06   ` Sakari Ailus
     [not found]     ` <169694430967.3973464.6599459439831458834@ping.linuxembedded.co.uk>
2023-10-11 11:01       ` Sakari Ailus
2023-10-10 17:09   ` Rob Herring
2023-10-10  0:51 ` [PATCH 2/5] media: i2c: imx335: Enable regulator supplies Kieran Bingham
2023-10-10  4:06   ` Umang Jain
2023-10-10  4:10   ` kernel test robot
2023-10-10  6:12   ` Sakari Ailus
     [not found]     ` <169701731909.277971.10840095252716847805@ping.linuxembedded.co.uk>
2023-10-11 11:06       ` Sakari Ailus
2023-10-10  0:51 ` [PATCH 3/5] media: i2c: imx335: Implement get selection API Kieran Bingham
2023-10-10  4:16   ` Umang Jain
2023-10-10  6:14   ` Sakari Ailus
     [not found]     ` <169701831889.277971.6656559808677876108@ping.linuxembedded.co.uk>
2023-10-11 11:12       ` Sakari Ailus
2023-10-10  0:51 ` [PATCH 4/5] media: i2c: imx335: Fix hblank min/max values Kieran Bingham
2023-10-10  4:15   ` Umang Jain [this message]
2023-10-10  0:51 ` [PATCH 5/5] media: i2c: imx335: Improve configuration error reporting Kieran Bingham
2023-10-10  3:36   ` Umang Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60a729ac-541a-6e92-34f4-411f78d010ec@ideasonboard.com \
    --to=umang.jain@ideasonboard.com \
    --cc=daniele.alessandrelli@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®