From: Sakari Ailus <sakari.ailus@iki.fi>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
"Paul J. Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] media: dt-bindings: media: imx335: Add supply bindings
Date: Tue, 10 Oct 2023 06:06:26 +0000 [thread overview]
Message-ID: <ZSTp4jXKPVrbo5oU@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20231010005126.3425444-2-kieran.bingham@ideasonboard.com>
Hi Kieran,
On Tue, Oct 10, 2023 at 01:51:22AM +0100, Kieran Bingham wrote:
> Add the bindings for the supply references used on the IMX335.
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> .../bindings/media/i2c/sony,imx335.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> index a167dcdb3a32..1863b5608a5c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> @@ -32,6 +32,15 @@ properties:
> description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz
> maxItems: 1
>
> + avdd-supply:
> + description: Analog power supply (2.9V)
> +
> + ovdd-supply:
> + description: Interface power supply (1.8V)
> +
> + dvdd-supply:
> + description: Digital power supply (1.2V)
I wonder what's the policy in this case --- some of the regulators are
often hard-wired and the bindings didn't have them previously either (I
wonder why, maybe they were all hard wired in the board??).
Could they be optional? The driver will need to be able to do without these
in any case.
> +
> reset-gpios:
> description: Reference to the GPIO connected to the XCLR pin, if any.
> maxItems: 1
> @@ -60,6 +69,9 @@ required:
> - compatible
> - reg
> - clocks
> + - avdd-supply
> + - ovdd-supply
> + - dvdd-supply
> - port
>
> additionalProperties: false
> @@ -79,6 +91,10 @@ examples:
> assigned-clock-parents = <&imx335_clk_parent>;
> assigned-clock-rates = <24000000>;
>
> + avdd-supply = <&camera_vdda_2v9>;
> + ovdd-supply = <&camera_vddo_1v8>;
> + dvdd-supply = <&camera_vddd_1v2>;
> +
> port {
> imx335: endpoint {
> remote-endpoint = <&cam>;
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2023-10-10 6:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231010005126.3425444-1-kieran.bingham@ideasonboard.com>
2023-10-10 0:51 ` Kieran Bingham
2023-10-10 3:53 ` Umang Jain
2023-10-10 5:03 ` Marco Felsch
2023-10-10 6:06 ` Sakari Ailus [this message]
[not found] ` <169694430967.3973464.6599459439831458834@ping.linuxembedded.co.uk>
2023-10-11 11:01 ` Sakari Ailus
2023-10-10 17:09 ` Rob Herring
2023-10-10 0:51 ` [PATCH 2/5] media: i2c: imx335: Enable regulator supplies Kieran Bingham
2023-10-10 4:06 ` Umang Jain
2023-10-10 4:10 ` kernel test robot
2023-10-10 6:12 ` Sakari Ailus
[not found] ` <169701731909.277971.10840095252716847805@ping.linuxembedded.co.uk>
2023-10-11 11:06 ` Sakari Ailus
2023-10-10 0:51 ` [PATCH 3/5] media: i2c: imx335: Implement get selection API Kieran Bingham
2023-10-10 4:16 ` Umang Jain
2023-10-10 6:14 ` Sakari Ailus
[not found] ` <169701831889.277971.6656559808677876108@ping.linuxembedded.co.uk>
2023-10-11 11:12 ` Sakari Ailus
2023-10-10 0:51 ` [PATCH 4/5] media: i2c: imx335: Fix hblank min/max values Kieran Bingham
2023-10-10 4:15 ` Umang Jain
2023-10-10 0:51 ` [PATCH 5/5] media: i2c: imx335: Improve configuration error reporting Kieran Bingham
2023-10-10 3:36 ` Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSTp4jXKPVrbo5oU@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=conor+dt@kernel.org \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®