mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shrybman <shrybman@teksavvy.com>
To: "Len Brown" <lenb@kernel.org>
Cc: "Len Brown" <len.brown@intel.com>, "X86 ML" <x86@kernel.org>,
	dparsons@brightdsl.net,
	"Linux PM list" <linux-pm@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000
Date: Thu, 05 Nov 2015 21:39:26 -0500	[thread overview]
Message-ID: <60ad3f7df9604e39d9af180f6b56bb69@teksavvy.com> (raw)
In-Reply-To: <CAJvTdKnagWXhA2sFD79fAx4oudrZ5CSPDFPt+g=+FTLHq27ncA@mail.gmail.com>

> > Is this really what you intended? The else is commented out so if init_udelay is quirked
> > to be 0 it will always be reset to UDELAY_10MS_DEFAULT. Also init_udelay is unsigned, so
> > would UINT_MAX be a better choice?
> 
> Hi Shane,
> Thanks for pointing out this flaw.
> Seems it will make 4.3 10ms slower than 4.2 on these boxes, by default.
> We'll send an incremental patch for 4.4.


Sounds good. Thanks Len.


  reply	other threads:[~2015-11-06  2:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16  4:14 [PATCH/RFT 0/2] regression fix: "smpboot: do_boot_cpu failed(-1) to wakeup CPU#1" Len Brown
2015-10-16  4:14 ` [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000 Len Brown
2015-10-16  4:14   ` [PATCH 2/2] x86 smpboot: fix CPU #1 boot timeout Len Brown
2015-10-19 17:48     ` [tip:x86/urgent] x86/smpboot: Fix " tip-bot for Len Brown
2015-10-16 19:34   ` [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000 shrybman
2015-11-03  5:16     ` Len Brown
2015-11-06  2:39       ` shrybman [this message]
2015-10-19 17:47   ` [tip:x86/urgent] x86/smpboot: Fix cpu_init_udelay= 10000 corner case boot parameter misbehavior tip-bot for Len Brown
2015-10-16  5:42 ` [PATCH/RFT 0/2] regression fix: "smpboot: do_boot_cpu failed(-1) to wakeup CPU#1" Donald Parsons
2015-10-16  6:12 ` shrybman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60ad3f7df9604e39d9af180f6b56bb69@teksavvy.com \
    --to=shrybman@teksavvy.com \
    --cc=dparsons@brightdsl.net \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®