From: Paolo Abeni <pabeni@redhat.com>
To: hawk@kernel.org, netdev@vger.kernel.org
Cc: "Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 3/5] veth: add tx_timeout watchdog as BQL safety net
Date: Thu, 4 Jun 2026 10:24:11 +0200 [thread overview]
Message-ID: <60c82009-790e-4be9-8651-309b14a6f55d@redhat.com> (raw)
In-Reply-To: <20260527135418.1166665-4-hawk@kernel.org>
On 5/27/26 3:54 PM, hawk@kernel.org wrote:
> @@ -1819,6 +1836,7 @@ static void veth_setup(struct net_device *dev)
> dev->priv_destructor = veth_dev_free;
> dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS;
> dev->max_mtu = ETH_MAX_MTU;
> + dev->watchdog_timeo = msecs_to_jiffies(16000);
Since a repost is neede it could be possibly usedfull using a macro for
the above constant and expanding the math leading to the actual value.
Also possibly an additional + 1 to avoid a very unlikely false positive
on exactly the maximum possible interval timer?
/P
next prev parent reply other threads:[~2026-06-04 8:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260527135418.1166665-1-hawk@kernel.org>
2026-05-27 13:54 ` [PATCH net-next v6 1/5] net: add dev->bql flag to allow BQL sysfs for IFF_NO_QUEUE devices hawk
2026-05-27 13:54 ` [PATCH net-next v6 2/5] veth: implement Byte Queue Limits (BQL) for latency reduction hawk
2026-05-28 7:45 ` Jonas Köppeler
2026-06-04 8:19 ` Paolo Abeni
2026-06-10 12:21 ` Jesper Dangaard Brouer
2026-05-27 13:54 ` [PATCH net-next v6 3/5] veth: add tx_timeout watchdog as BQL safety net hawk
2026-06-04 8:24 ` Paolo Abeni [this message]
2026-06-10 12:37 ` Jesper Dangaard Brouer
2026-05-27 13:54 ` [PATCH net-next v6 4/5] net: sched: add timeout count to NETDEV WATCHDOG message hawk
2026-06-04 8:30 ` Paolo Abeni
2026-06-12 9:39 ` Jesper Dangaard Brouer
2026-05-27 13:54 ` [PATCH net-next v6 5/5] veth: time-based BQL completion coalescing via ethtool tx-usecs hawk
2026-05-28 7:46 ` Jonas Köppeler
2026-06-01 12:00 ` Simon Schippers
2026-06-01 14:03 ` Jonas Köppeler
2026-06-01 16:16 ` Simon Schippers
2026-06-02 7:24 ` Jonas Köppeler
2026-06-02 15:37 ` Simon Schippers
2026-06-03 8:28 ` Jonas Köppeler
2026-05-29 14:51 ` Simon Schippers
2026-06-04 8:21 ` Paolo Abeni
2026-06-08 10:38 ` Simon Schippers
2026-06-08 13:04 ` Jesper Dangaard Brouer
2026-06-08 13:13 ` Jonas Köppeler
2026-06-08 14:21 ` Simon Schippers
2026-06-09 13:59 ` Jesper Dangaard Brouer
2026-06-09 15:08 ` Simon Schippers
2026-06-10 7:04 ` Simon Schippers
2026-06-10 10:15 ` Jesper Dangaard Brouer
2026-06-10 12:00 ` Simon Schippers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60c82009-790e-4be9-8651-309b14a6f55d@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=j.koeppeler@tu-berlin.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®