mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	PDx86 <platform-driver-x86@vger.kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [GIT PULL] platform-drivers-x86 for v7.2-1
Date: Tue, 23 Jun 2026 19:25:33 +0200	[thread overview]
Message-ID: <60e45b3b-7c47-44bb-ae3f-7b3579633434@oss.qualcomm.com> (raw)
In-Reply-To: <CAJZ5v0g8GUJxy3TPfXa=Hjwk2puYKUpAZzdbo35houPEBLs6cA@mail.gmail.com>

On 6/23/26 18:53, Rafael J. Wysocki wrote:
> On Tue, Jun 23, 2026 at 5:37 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> On Mon, 22 Jun 2026 at 11:42, Ilpo Järvinen
>> <ilpo.jarvinen@linux.intel.com> wrote:
>>>
>>> There is going to be a conflict with the commit 3570cb58e317 ("thermal/of:
>>> Pass cdev_id and introduce devm registration helper") and a few other
>>> commits that came from thermal tree effectively resulting in a change in
>>> devm_thermal_of_cooling_device_register() signature. It needs to be
>>> addressed in the merge commit or the build will fail.
>>>
>>> Mark's linux-next discovery about the build failure:
>>>
>>>    https://lore.kernel.org/all/aibZy5rrdX3ltGpr@sirena.org.uk/
>>
>> That resolution makes absolutely no sense.
>>
>> Now that qcom_ec_probe() goes through all the work to create a name for the fan:
>>
>>                  char name[EC_FAN_NAME_SIZE];
>>
>>                  scnprintf(name, sizeof(name), "qcom_ec_fan_%u", i);
>>
>> but then the name is actually never *used* after the change.
>>
>> The *logical* resolution would be to make it use
>>
>>     devm_thermal_of_child_cooling_device_register()
>>
>> instead, which that function was renamed to in commit 8e1529e79385
>> ("thermal/of: Rename the devm_thermal_of_cooling_device_register()
>> function")
>>
>> I have done that resolution that at least makes sense.
>>
>> But honestly, this is all a complete mess.
>>
>> Why the hell was that function renamed, and then a new function
>> created with the old name - when that new function then has exactly
>> ZERO users?
>>
>> Renaming a function, and then re-using the old name immediately for
>> something else is a BAD IDEA. It causes exactly this kind of horrible
>> confusion. It's an even worse idea when there are exactly zero new
>> users that make that confusion worthwhile.
>>
>> Thermal people - you effed up. Stop doing this kind of crap. This is insanity.
> 
> Right, the new function should have been given a different name.
> 
> Sorry for letting this slip in.

Yes, sorry for that. I'll take care of not reusing the same function 
name in the future

  reply	other threads:[~2026-06-23 17:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 18:15 Ilpo Järvinen
2026-06-23 15:37 ` Linus Torvalds
2026-06-23 16:53   ` Rafael J. Wysocki
2026-06-23 17:25     ` Daniel Lezcano [this message]
2026-06-23 18:51       ` Linus Torvalds
2026-06-23 15:40 ` pr-tracker-bot
2026-06-23 15:40 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60e45b3b-7c47-44bb-ae3f-7b3579633434@oss.qualcomm.com \
    --to=daniel.lezcano@oss.qualcomm.com \
    --cc=andy@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®