From: "Oliver Pinter" <oliver.pntr@gmail.com>
To: "Andi Kleen" <andi@firstfloor.org>
Cc: mingo@elte.hu, davej@codemonkey.org.uk, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use global TLB flushes in MTRR code
Date: Thu, 7 Feb 2008 20:08:04 +0100 [thread overview]
Message-ID: <6101e8c40802071108i4e66be5r4e9a6e77421beaae@mail.gmail.com> (raw)
In-Reply-To: <20080207190241.GA9449@basil.nowhere.org>
and old-stable (eg 2.6.22)?
On 2/7/08, Andi Kleen <andi@firstfloor.org> wrote:
> [probably stable material too]
>
> Use global TLB flushes in MTRR code
>
> Obviously kernel mappings should be flushed here too.
>
> Signed-off-by: Andi Kleen <ak@suse.de>
>
> ---
> arch/x86/kernel/cpu/mtrr/generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/arch/x86/kernel/cpu/mtrr/generic.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/cpu/mtrr/generic.c
> +++ linux/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -356,7 +356,7 @@ static void prepare_set(void) __acquires
> }
>
> /* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */
> - __flush_tlb();
> + __flush_tlb_all();
>
> /* Save MTRR state */
> rdmsr(MTRRdefType_MSR, deftype_lo, deftype_hi);
> @@ -368,7 +368,7 @@ static void prepare_set(void) __acquires
> static void post_set(void) __releases(set_atomicity_lock)
> {
> /* Flush TLBs (no need to flush caches - they are disabled) */
> - __flush_tlb();
> + __flush_tlb_all();
>
> /* Intel (P6) standard MTRRs */
> mtrr_wrmsr(MTRRdefType_MSR, deftype_lo, deftype_hi);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Thanks,
Oliver
next prev parent reply other threads:[~2008-02-07 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 19:02 Andi Kleen
2008-02-07 19:08 ` Oliver Pinter [this message]
2008-02-07 19:13 ` Ingo Molnar
2008-02-07 20:03 ` Andi Kleen
2008-02-07 20:37 ` Ingo Molnar
2008-02-08 11:44 ` Andi Kleen
2008-02-09 9:40 ` Ingo Molnar
2008-02-09 11:48 ` Andi Kleen
2008-02-09 11:47 ` Ingo Molnar
2008-02-09 14:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6101e8c40802071108i4e66be5r4e9a6e77421beaae@mail.gmail.com \
--to=oliver.pntr@gmail.com \
--cc=andi@firstfloor.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome