From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Aaron Lu <ziqianlu@bytedance.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Florian Bezdeka <florian.bezdeka@siemens.com>,
Valentin Schneider <vschneid@redhat.com>,
Ben Segall <bsegall@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Don <joshdon@google.com>, Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Xi Wang <xii@google.com>, <linux-kernel@vger.kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mel Gorman <mgorman@suse.de>,
Chengming Zhou <chengming.zhou@linux.dev>,
Chuyi Zhou <zhouchuyi@bytedance.com>,
"Sebastian Andrzej Siewior," <bigeasy@linutronix.de>
Subject: Re: [RFC PATCH v2 0/7] Defer throttle when task exits to user
Date: Tue, 22 Apr 2025 08:24:21 +0530 [thread overview]
Message-ID: <610fcbfa-a8e7-483c-a112-579879628b99@amd.com> (raw)
In-Reply-To: <20250421120648.GA3357499@bytedance>
Hello Aaron,
On 4/22/2025 7:40 AM, Aaron Lu wrote:
>> anon_pipe_write()
>> __wake_up_common()
>> ep_poll_callback() {
>> read_lock_irq(&ep->lock) /* Read lock acquired here */
> I was confused by this function's name. I had thought irq is off but
> then realized under PREEMPT_RT, read_lock_irq() doesn't disable irq...
Yup! Most of the interrupt handlers are run by the IRQ threads on
PREEMPT_RT and the ones that do run in the interrupt context have all
been adapted to use non-blocking locks whose *_irq variants disables
interrupts on PREEMPT_RT too.
>
>> __wake_up_common()
>> ep_autoremove_wake_function()
>> try_to_wake_up() /* Wakes up "epoll-stall" */
>> preempt_schedule()
>> ...
>>
>> # "epoll-stall-writer" has run out of bandwidth, needs replenish to run
> Luckily in this "only throttle when ret2user" model, epoll-stall-writer
> does not need replenish to run again(and then unblock the others).
I can confirm that throttle deferral solves this issue. I have run Jan's
reproducer for a long time without seeing any hangs on your series. I
hope Florian can confirm the same.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2025-04-22 2:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 12:07 Aaron Lu
2025-04-09 12:07 ` [RFC PATCH v2 1/7] sched/fair: Add related data structure for task based throttle Aaron Lu
2025-04-14 3:58 ` K Prateek Nayak
2025-04-14 11:55 ` Aaron Lu
2025-04-14 13:37 ` K Prateek Nayak
2025-04-09 12:07 ` [RFC PATCH v2 2/7] sched/fair: Handle throttle path " Aaron Lu
2025-04-14 8:54 ` Florian Bezdeka
2025-04-14 12:10 ` Aaron Lu
2025-04-14 14:39 ` Florian Bezdeka
2025-04-14 15:02 ` K Prateek Nayak
2025-04-30 10:01 ` Aaron Lu
2025-04-09 12:07 ` [RFC PATCH v2 3/7] sched/fair: Handle unthrottle " Aaron Lu
2025-04-09 12:07 ` [RFC PATCH v2 4/7] sched/fair: Take care of group/affinity/sched_class change for throttled task Aaron Lu
2025-04-09 12:07 ` [RFC PATCH v2 5/7] sched/fair: get rid of throttled_lb_pair() Aaron Lu
2025-04-09 12:07 ` [RFC PATCH v2 6/7] sched/fair: fix h_nr_runnable accounting with per-task throttle Aaron Lu
2025-04-09 12:07 ` [RFC PATCH v2 7/7] sched/fair: alternative way of accounting throttle time Aaron Lu
2025-04-09 14:24 ` Aaron Lu
2025-04-17 14:06 ` Florian Bezdeka
2025-04-18 3:15 ` Aaron Lu
2025-04-22 15:03 ` Florian Bezdeka
2025-04-23 11:26 ` Aaron Lu
2025-04-23 12:15 ` Florian Bezdeka
2025-04-24 2:26 ` Aaron Lu
2025-05-07 9:09 ` Aaron Lu
2025-05-07 9:33 ` Florian Bezdeka
2025-05-08 2:45 ` Aaron Lu
2025-05-08 6:13 ` Jan Kiszka
2025-05-08 13:43 ` Steven Rostedt
2025-04-14 3:05 ` [RFC PATCH v2 0/7] Defer throttle when task exits to user Chengming Zhou
2025-04-14 11:47 ` Aaron Lu
2025-04-14 8:54 ` Florian Bezdeka
2025-04-14 12:04 ` Aaron Lu
2025-04-15 5:29 ` Jan Kiszka
2025-04-15 6:05 ` K Prateek Nayak
2025-04-15 6:09 ` Jan Kiszka
2025-04-15 8:45 ` K Prateek Nayak
2025-04-15 10:21 ` Jan Kiszka
2025-04-15 11:14 ` K Prateek Nayak
[not found] ` <ec2cea83-07fe-472f-8320-911d215473fd@amd.com>
2025-04-15 15:49 ` K Prateek Nayak
2025-04-22 2:10 ` Aaron Lu
2025-04-22 2:54 ` K Prateek Nayak [this message]
2025-04-22 14:54 ` Florian Bezdeka
2025-04-15 10:34 ` K Prateek Nayak
2025-04-14 16:34 ` K Prateek Nayak
2025-04-15 11:25 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610fcbfa-a8e7-483c-a112-579879628b99@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=florian.bezdeka@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=xii@google.com \
--cc=zhouchuyi@bytedance.com \
--cc=ziqianlu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®