From: "Indan Zupancic" <indan@nul.nu>
To: "Takashi Iwai" <tiwai@suse.de>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Alex Riesen" <raa.lkml@gmail.com>,
"Jesse Barnes" <jbarnes@virtuousgeek.org>,
"DRI mailing list" <dri-devel@lists.freedesktop.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Tino Keitel" <tino.keitel@tikei.de>,
stable@kernel.org
Subject: Re: [PATCH] drm/i915: Revive combination mode for backlight control
Date: Fri, 11 Mar 2011 10:08:21 +0100 (CET) [thread overview]
Message-ID: <6137e754bd8453a60f892b0f03663352.squirrel@webmail.greenhost.nl> (raw)
In-Reply-To: <s5hd3lyrubr.wl%tiwai@suse.de>
On Fri, March 11, 2011 08:26, Takashi Iwai wrote:
> At Fri, 11 Mar 2011 02:23:08 +0100 (CET),
> Indan Zupancic wrote:
>>
>> Hi,
>>
>> Some nitpicks below. I know you're just restoring the original code,
>> but if we improve it we can as well do it now.
>
> Well, Linus already merged my patch quickly. So, we can improve the
> readability as an additional patch, but I think it's likely a 2.6.39
> material.
>
> All you comments below look reasonable. Could you send a new patch?
Well, my main concern was the slightly incorrect commit message,
but oh well, too late for that now. I'll probably send a patch
after 2.6.38 is released.
Greetings,
Indan
next prev parent reply other threads:[~2011-03-11 9:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 4:16 Linux 2.6.38-rc5 Linus Torvalds
2011-02-16 11:14 ` Eric Dumazet
2011-02-16 13:55 ` Eric Dumazet
2011-02-16 15:46 ` Linus Torvalds
2011-02-16 16:06 ` Al Viro
2011-02-16 16:19 ` Al Viro
2011-02-16 16:33 ` Linus Torvalds
2011-02-16 16:39 ` Al Viro
2011-02-16 16:47 ` Eric Dumazet
2011-02-16 16:22 ` Eric Dumazet
2011-02-16 19:26 ` [PATCH] fix backlight brightness on intel LVDS panel after reopening lid Alex Riesen
2011-02-16 19:46 ` Alex Riesen
2011-02-16 19:54 ` Jesse Barnes
2011-02-16 19:59 ` Alex Riesen
2011-02-16 20:05 ` Jesse Barnes
2011-02-16 20:28 ` Alex Riesen
2011-02-17 1:41 ` [PATCH] drm/i915: Do not handle backlight combination mode specially Indan Zupancic
2011-02-17 22:13 ` [PATCH] fix backlight brightness on intel LVDS panel after reopening lid Tino Keitel
2011-02-18 4:57 ` Indan Zupancic
2011-02-19 12:11 ` Alex Riesen
2011-02-19 12:26 ` Alex Riesen
2011-02-19 23:07 ` Linus Torvalds
2011-02-22 21:04 ` Jesse Barnes
2011-02-22 22:31 ` Tino Keitel
2011-02-23 1:09 ` Linus Torvalds
2011-03-04 6:53 ` Indan Zupancic
2011-03-04 18:47 ` Linus Torvalds
2011-03-04 23:32 ` Indan Zupancic
2011-03-06 17:40 ` Alex Riesen
2011-03-10 5:50 ` Indan Zupancic
2011-03-10 6:00 ` Indan Zupancic
2011-03-10 7:49 ` Takashi Iwai
2011-03-10 8:25 ` Takashi Iwai
2011-03-10 10:06 ` Indan Zupancic
2011-03-10 12:59 ` Takashi Iwai
2011-03-10 13:02 ` [PATCH] drm/i915: Revive combination mode for backlight control Takashi Iwai
2011-03-10 19:36 ` Keith Packard
2011-03-11 1:30 ` Indan Zupancic
2011-03-11 1:23 ` Indan Zupancic
2011-03-11 1:28 ` Linus Torvalds
2011-03-11 7:26 ` Takashi Iwai
2011-03-11 9:08 ` Indan Zupancic [this message]
2011-03-11 7:34 ` Keith Packard
2011-03-10 8:45 ` [PATCH] fix backlight brightness on intel LVDS panel after reopening lid Indan Zupancic
2011-03-10 12:51 ` Takashi Iwai
2011-03-05 0:26 ` Peter Stuge
2011-02-23 1:32 ` Indan Zupancic
2011-02-20 14:03 ` Linux 2.6.38-rc5 Paul Rolland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6137e754bd8453a60f892b0f03663352.squirrel@webmail.greenhost.nl \
--to=indan@nul.nu \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raa.lkml@gmail.com \
--cc=stable@kernel.org \
--cc=tino.keitel@tikei.de \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome