From: Trond Myklebust <trondmy@primarydata.com>
To: Rob Landley <rob@landley.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Fix NFS option parsing bit-rot.
Date: Wed, 8 Jun 2016 20:35:21 +0000 [thread overview]
Message-ID: <615FD41F-9C7D-4BAA-8BC5-D1F3CA115A8E@primarydata.com> (raw)
In-Reply-To: <575874E5.3070809@landley.net>
On 6/8/16, 15:41, "Rob Landley" <rob@landley.net> wrote:
>So addr= is at _best_ redundant. You MUST supply host:/ always,
>the current code just wasn't using it.
That’s because you just happen to be supplying an IP address instead of a hostname. The kernel has no DNS resolving functionality. It cannot resolve hostnames into IP addresses without help either by the caller or by means of an upcall. That is why ‘addr=’ has been a mandatory parameter ever since we introduced the text based parser.
Now we could, theoretically, have the client call nfs_dns_resolve_name() on the hostname to resolve it. However that breaks when you have net namespaces and such, since the kernel’s dns_query() call is not container aware.
Trond
next prev parent reply other threads:[~2016-06-08 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 22:58 Rob Landley
2016-06-06 23:49 ` Trond Myklebust
2016-06-08 19:41 ` Rob Landley
2016-06-08 20:35 ` Trond Myklebust [this message]
2016-06-08 21:51 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=615FD41F-9C7D-4BAA-8BC5-D1F3CA115A8E@primarydata.com \
--to=trondmy@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®