From: Philipp Zabel <p.zabel@pengutronix.de>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
Ryan Chen <ryanchen.aspeed@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Andrew Jeffery <andrew@aj.id.au>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Add ast2700 support
Date: Mon, 16 Mar 2026 10:44:04 +0100 [thread overview]
Message-ID: <618f82e69dab57f9ba335e2fc4bb62d2d601f7cc.camel@pengutronix.de> (raw)
In-Reply-To: <TY2PPF5CB9A1BE6CFB3FA0165159C68D3F0F242A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
On Sa, 2026-03-14 at 01:21 +0000, Ryan Chen wrote:
[...]
> >
> > Thanks the guidance.
> > I will update use
> > sdc->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
> > if (IS_ERR(sdc->rst))
> > return dev_err_probe(&pdev->dev, PTR_ERR(sdc->rst),
> > "unable to acquire reset\n");
> >
> Sorry, I review the devm_reset_control_get_optional_exclusive_deasserted
> I will modify with following in probe.
>
> sdc->rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
> NULL);
> if (IS_ERR(sdc->rst))
> return dev_err_probe(&pdev->dev, PTR_ERR(sdc->rst),
> "unable to acquire reset\n");
>
> And add reset_control_assert(sdc->rst); in remove.
Only do one of those two changes. The devm_..._deasserted() function
will call reset_control_assert() automatically. See:
https://docs.kernel.org/driver-api/reset.html#c.devm_reset_control_get_optional_exclusive_deasserted
regards
Philipp
next prev parent reply other threads:[~2026-03-16 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 5:27 [PATCH 0/2] Add AST2700 support for aspeed sdhci Ryan Chen
2026-03-13 5:27 ` [PATCH 1/2] dt-bindings: mmc: sdhci-of-aspeed : Add ast2700 support Ryan Chen
2026-03-14 10:23 ` Krzysztof Kozlowski
2026-03-16 1:59 ` Ryan Chen
2026-03-14 10:24 ` Krzysztof Kozlowski
2026-03-13 5:27 ` [PATCH 2/2] mmc: sdhci-of-aspeed: " Ryan Chen
2026-03-13 8:25 ` Philipp Zabel
2026-03-13 8:35 ` Ryan Chen
2026-03-14 1:21 ` Ryan Chen
2026-03-16 9:44 ` Philipp Zabel [this message]
2026-03-16 9:51 ` Ryan Chen
2026-03-14 10:23 ` Krzysztof Kozlowski
2026-03-16 5:51 ` Ryan Chen
2026-03-14 20:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618f82e69dab57f9ba335e2fc4bb62d2d601f7cc.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=ryanchen.aspeed@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®