mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>,
	admiyo@os.amperecomputing.com,
	 Matt Johnston <matt@codeconstruct.com.au>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sudeep Holla <sudeep.holla@arm.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Mon, 01 Sep 2025 08:59:28 +0800	[thread overview]
Message-ID: <61914df7e54eb4279627697ceb11f8aae0e5b77b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <25237d53-a93d-4c1f-a7a4-4b6ed03e10e4@oracle.com>

Hi Adam,

+1 on all the recommended changes from Alok, except for:

> > +               return -EINVAL;
> > +       }
> > +
> > +       snprintf(name, sizeof(name), "mctpipcc%d", context.inbox_index);
> 
> mctp_pcc%d ?

Please keep this as you have in v27, as mctppcc%d, so we're consistent
with other MCTP interface naming.

Cheers,



Jeremy

  reply	other threads:[~2025-09-01  1:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27  4:48 [PATCH net-next v25 0/1] MCTP Over " admiyo
2025-08-27  4:48 ` [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over " admiyo
2025-08-27  7:36   ` Jeremy Kerr
2025-08-27 17:54   ` kernel test robot
2025-08-29  9:17   ` kernel test robot
2025-08-29 19:32   ` ALOK TIWARI
2025-09-01  0:59     ` Jeremy Kerr [this message]
2025-09-05 17:25     ` Adam Young
2025-08-27  4:57 ` [PATCH net-next v25 0/1] MCTP Over " Adam Young
  -- strict thread matches above, loose matches on Subject: below --
2025-08-19 20:51 admiyo
2025-08-19 20:51 ` [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over " admiyo
2025-08-22  8:21   ` Jeremy Kerr
2025-08-26 20:51     ` Adam Young
2025-08-27  1:37       ` Jeremy Kerr
2025-08-27  4:55         ` Adam Young
2025-08-26 22:37     ` Adam Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61914df7e54eb4279627697ceb11f8aae0e5b77b.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=admiyo@os.amperecomputing.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=lihuisong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®