From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>,
admiyo@os.amperecomputing.com,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Tue, 26 Aug 2025 16:51:05 -0400 [thread overview]
Message-ID: <d15313f4-46d1-4096-bdf1-783afd8e439d@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <88a67cc10907926204a478c58e361cb6706a939a.camel@codeconstruct.com.au>
In addition to the below comment, I am removing the additional lock on
the skb lists and using the internal one for all operations. It leads
to leaner and cleaner code.
Updated driver shortly.
On 8/22/25 04:21, Jeremy Kerr wrote:
>> + mctp_pcc_ndev->inbox.chan->rx_alloc = mctp_pcc_rx_alloc;
>> + mctp_pcc_ndev->outbox.chan->manage_writes = true;
>> +
>> + /* There is no clean way to pass the MTU to the callback function
>> + * used for registration, so set the values ahead of time.
>> + */
> For my own clarity, what's "the callback function used for
> registration"?
Actually, this is not longer true: we can do it in ndo_open, and it is
clean. Removed the comment.
next prev parent reply other threads:[~2025-08-26 20:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 20:51 [PATCH net-next v25 0/1] MCTP Over " admiyo
2025-08-19 20:51 ` [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over " admiyo
2025-08-22 8:21 ` Jeremy Kerr
2025-08-26 20:51 ` Adam Young [this message]
2025-08-27 1:37 ` Jeremy Kerr
2025-08-27 4:55 ` Adam Young
2025-08-26 22:37 ` Adam Young
2025-08-27 4:48 [PATCH net-next v25 0/1] MCTP Over " admiyo
2025-08-27 4:48 ` [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over " admiyo
2025-08-27 7:36 ` Jeremy Kerr
2025-08-27 17:54 ` kernel test robot
2025-08-29 9:17 ` kernel test robot
2025-08-29 19:32 ` ALOK TIWARI
2025-09-01 0:59 ` Jeremy Kerr
2025-09-05 17:25 ` Adam Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d15313f4-46d1-4096-bdf1-783afd8e439d@amperemail.onmicrosoft.com \
--to=admiyo@amperemail.onmicrosoft.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®