mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Nishanth Menon <nm@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Bao Cheng Su <baocheng.su@siemens.com>,
	Hua Qian Li <huaqian.li@siemens.com>,
	Diogo Ivo <diogo.ivo@siemens.com>
Subject: Re: [PATCH v2 1/6] dt-bindings: soc: ti: Add AM65 peripheral virtualization unit
Date: Tue, 27 Aug 2024 11:29:14 +0200	[thread overview]
Message-ID: <61a3467a-ed7c-4827-924e-c100d9078a7a@siemens.com> (raw)
In-Reply-To: <6m4znz74jzktnyjmt2sec3gudr7cij4xax4b27qb5ypcnllely@dw5z576bge6j>

On 27.08.24 08:36, Krzysztof Kozlowski wrote:
> On Mon, Aug 26, 2024 at 11:50:02PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> The PVU allows to define a limited set of mappings for incoming DMA
>> requests to the system memory. It is not a real IOMMU, thus hooked up
>> under the TI SoC bindings.
> 
> You still keep developing it on wrong, old kernel (or not using
> get_maintainers.pl, but this one seems too obvious so I assumed wrong
> kernel).

Explained elsewhere, will update the two subtly changed addresses in the
next round.

> 
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  .../bindings/soc/ti/ti,am654-pvu.yaml         | 51 +++++++++++++++++++
>>  1 file changed, 51 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/soc/ti/ti,am654-pvu.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-pvu.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-pvu.yaml
>> new file mode 100644
>> index 000000000000..fd0f86fa27b0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-pvu.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (c) Siemens AG, 2024
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/soc/ti/ti,am654-pvu.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI AM654 Peripheral Virtualization Unit
>> +
>> +maintainers:
>> +  - Jan Kiszka <jan.kiszka@siemens.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,am654-pvu
>> +
>> +  reg:
>> +    minItems: 2
> 
> maxItems instead.

Can change, but maybe use the chance to explain to me why "maxItems" and
why also "instead".

> 
>> +
>> +  reg-names:
>> +    items:
>> +      - const: cfg
>> +      - const: tlbif
>> +
>> +  interrupts:
>> +    items:
>> +      - description: fault interrupt
>> +
>> +  interrupt-names:
>> +    items:
>> +      - const: pvu
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - interrupt-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    ti-pvu@30f80000 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> for sure "ti" is not generic. pvu is the device name.

No problem - which one do you propose for this type of device?

Thanks,
Jan

-- 
Siemens AG, Technology
Linux Expert Center


  reply	other threads:[~2024-08-27  9:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 21:50 [PATCH v2 0/6] soc: ti: Add and use PVU on K3-AM65 for DMA isolation Jan Kiszka
2024-08-26 21:50 ` [PATCH v2 1/6] dt-bindings: soc: ti: Add AM65 peripheral virtualization unit Jan Kiszka
2024-08-27  6:36   ` Krzysztof Kozlowski
2024-08-27  9:29     ` Jan Kiszka [this message]
2024-08-27 10:35       ` Krzysztof Kozlowski
2024-08-26 21:50 ` [PATCH v2 2/6] soc: ti: Add IOMPU-like PVU driver Jan Kiszka
2024-08-26 21:50 ` [PATCH v2 3/6] dt-bindings: PCI: ti,am65: Extend for use with PVU Jan Kiszka
2024-08-27  6:37   ` Krzysztof Kozlowski
2024-08-27  9:22     ` Jan Kiszka
2024-08-27  9:29       ` Krzysztof Kozlowski
2024-08-27  9:32         ` Jan Kiszka
2024-08-27 10:06           ` Siddharth Vadapalli
2024-08-27 10:46             ` Jan Kiszka
2024-08-27 10:54               ` Krzysztof Kozlowski
2024-08-27 10:44     ` Jan Kiszka
2024-08-27 10:55       ` Krzysztof Kozlowski
2024-08-26 21:50 ` [PATCH v2 4/6] arm64: dts: ti: k3-am65-main: Add VMAP registers to PCI root complexes Jan Kiszka
2024-08-26 21:50 ` [PATCH v2 5/6] PCI: keystone: Add supported for PVU-based DMA isolation on AM654 Jan Kiszka
2024-08-26 21:50 ` [PATCH v2 6/6] arm64: dts: ti: iot2050: Enforce DMA isolation for devices behind PCI RC Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a3467a-ed7c-4827-924e-c100d9078a7a@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=baocheng.su@siemens.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=diogo.ivo@siemens.com \
    --cc=huaqian.li@siemens.com \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®