From: Qunqin Zhao <zhaoqunqin@loongson.cn>
To: Borislav Petkov <bp@alien8.de>
Cc: Qunqin Zhao <zhaoqunqin@163.com>,
tony.luck@intel.com, linux-edac@vger.kernel.org,
chenhuacai@kernel.org, linux-kernel@vger.kernel.org,
Wang Jinwei <wangjinwei@loongson.cn>,
Yulong Wang <wangyulong@loongson.cn>,
Dongyan Qian <qiandongyan@loongson.cn>,
Chao Li <lichao@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH v6 2/4] EDAC/loongson: Encode node and MC info into mc_idx
Date: Tue, 10 Nov 2026 16:23:29 +0800 [thread overview]
Message-ID: <61dc34e7-e872-42cb-a0b1-be100a78053a@loongson.cn> (raw)
In-Reply-To: <20261110080338.GJavLP2h448voZSQRE@fat_crate.local>
在 2026/11/10 16:03, Borislav Petkov 写道:
> On Tue, Nov 10, 2026 at 03:47:20PM +0800, Qunqin Zhao wrote:
>> "all your nodes belong to memory controller 0"
>> I don't quite follow this sentence. There are four memory controllers on LS3C6000/S.
>>
>> On firmware without mc-idx there can still be more than one memory controller
> So edac_device_alloc_index() is used to give out indices for other EDAC
> devices with edac_device_alloc_ctl_info() but I guess you could use that in
> your driver until you don't need to add other devices besides MCs and then
> it'll become a mess...
>
> Lemme ask the simplest question first: is there any case where ACPI won't
mc-idx is not guaranteed. There is firmware that does not provide the property.
Qunqin,
Thanks.
> provide that _DSD property or you're in control of the firmware - not like on
> x86 - and this case we're trying to fix is never going to happen anyway...?
>
> Thx.
>
next prev parent reply other threads:[~2026-11-10 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 2:55 [PATCH v6 0/4] EDAC/loongson: Improvements for Loongson EDAC driver Qunqin Zhao
2026-11-05 2:55 ` [PATCH v6 1/4] EDAC/loongson: Rename driver-local symbols Qunqin Zhao
2026-11-05 7:10 ` Huacai Chen
2026-11-05 2:55 ` [PATCH v6 2/4] EDAC/loongson: Encode node and MC info into mc_idx Qunqin Zhao
2026-11-10 6:41 ` Borislav Petkov
2026-11-10 7:47 ` Qunqin Zhao
2026-11-10 8:03 ` Borislav Petkov
2026-11-10 8:23 ` Qunqin Zhao [this message]
2026-11-10 18:31 ` Borislav Petkov
2026-11-11 6:37 ` Qunqin Zhao
2026-11-11 8:08 ` Borislav Petkov
2026-11-11 8:33 ` Qunqin Zhao
2026-11-05 2:55 ` [PATCH v6 3/4] EDAC/loongson: Get DIMM size from ACPI _DSM method Qunqin Zhao
2026-11-05 2:55 ` [PATCH v6 4/4] EDAC/loongson: Add CS4-7 timeout filter for cross-node access Qunqin Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61dc34e7-e872-42cb-a0b1-be100a78053a@loongson.cn \
--to=zhaoqunqin@loongson.cn \
--cc=bp@alien8.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=lichao@loongson.cn \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiandongyan@loongson.cn \
--cc=tony.luck@intel.com \
--cc=wangjinwei@loongson.cn \
--cc=wangyulong@loongson.cn \
--cc=zhaoqunqin@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®