mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Quan Nguyen <quan@os.amperecomputing.com>
To: Jian Zhang <zhangjian.3032@bytedance.com>,
	Corey Minyard <corey@minyard.net>,
	openipmi-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ipmi: ssif_bmc: fix message desynchronization after truncated response
Date: Fri, 3 Apr 2026 14:22:41 +0700	[thread overview]
Message-ID: <61e671d8-01a8-4544-93a1-73e30f30ae7d@os.amperecomputing.com> (raw)
In-Reply-To: <20260402110435.3589408-3-zhangjian.3032@bytedance.com>



On 2/4/26 18:04, Jian Zhang wrote:
> A truncated response, caused by host power-off, or other conditions,
> can lead to message desynchronization.
> 
> Raw trace data (STOP loss scenario, add state transition comment):
> 
> 1. T-1: Read response phase (SSIF_RES_SENDING)
> 8271.955342  WR_RCV [03]                          <- Read polling cmd
> 8271.955348  RD_REQ [04]  <== SSIF_RES_SENDING    <- start sending response
> 8271.955436  RD_PRO [b4]
> 8271.955527  RD_PRO [00]
> 8271.955618  RD_PRO [c1]
> 8271.955707  RD_PRO [00]
> 8271.955814  RD_PRO [ad]  <== SSIF_RES_SENDING     <- last byte
> 	<- !! STOP lost (truncated response)

Honestly, I have a little concern about if there is the case. What I 
think is that if there was no ACK (SCA is not pull low by Controller) on 
the 9th clock pulse while Target sending data to bus. Target will 
release SDA line, eventually, there will be a STOP condition and a 
SLAVE_STOP event should be emitted.

- Quan

  reply	other threads:[~2026-04-03  7:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 11:04 [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove Jian Zhang
2026-04-02 11:04 ` [PATCH 2/5] ipmi: ssif_bmc: fix missing check for copy_to_user() partial failure Jian Zhang
2026-04-02 11:04 ` [PATCH 3/5] ipmi: ssif_bmc: fix message desynchronization after truncated response Jian Zhang
2026-04-03  7:22   ` Quan Nguyen [this message]
2026-04-03  8:12     ` Jian Zhang
2026-04-02 11:04 ` [PATCH 4/5] ipmi: ssif_bmc: change log level to dbg in irq callback Jian Zhang
2026-04-02 11:04 ` [PATCH 5/5] ipmi: ssif_bmc: add unit test for state machine Jian Zhang
2026-04-02 15:42 ` [Openipmi-developer] [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove Corey Minyard
2026-04-03  7:23   ` Quan Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61e671d8-01a8-4544-93a1-73e30f30ae7d@os.amperecomputing.com \
    --to=quan@os.amperecomputing.com \
    --cc=corey@minyard.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=zhangjian.3032@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®