mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Quan Nguyen <quan@os.amperecomputing.com>
To: corey@minyard.net, Jian Zhang <zhangjian.3032@bytedance.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Openipmi-developer] [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove
Date: Fri, 3 Apr 2026 14:23:20 +0700	[thread overview]
Message-ID: <233889df-38ae-4878-afe9-5d23d74be00f@os.amperecomputing.com> (raw)
In-Reply-To: <ac6Og2aNEoT0p2xj@mail.minyard.net>



On 2/4/26 22:42, Corey Minyard wrote:
> On Thu, Apr 02, 2026 at 07:04:31PM +0800, Jian Zhang via Openipmi-developer wrote:
>> The response timer can stay armed across device teardown. If it fires after
>> remove, the callback dereferences the SSIF context and the i2c client after
>> teardown has started.
>>
>> Cancel the timer in remove so the callback cannot run after the device is
>> unregistered.
> 
> This whole series looks good to me, and I have added it to my next tree.
> I'd like to hear from Quan, though.
> 

The whole series looks good to me too. Just a little concern on the 3/5 
part as we have not yet encountered.

Thanks for the patches
-- Quan

      reply	other threads:[~2026-04-03  7:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 11:04 Jian Zhang
2026-04-02 11:04 ` [PATCH 2/5] ipmi: ssif_bmc: fix missing check for copy_to_user() partial failure Jian Zhang
2026-04-02 11:04 ` [PATCH 3/5] ipmi: ssif_bmc: fix message desynchronization after truncated response Jian Zhang
2026-04-03  7:22   ` Quan Nguyen
2026-04-03  8:12     ` Jian Zhang
2026-04-02 11:04 ` [PATCH 4/5] ipmi: ssif_bmc: change log level to dbg in irq callback Jian Zhang
2026-04-02 11:04 ` [PATCH 5/5] ipmi: ssif_bmc: add unit test for state machine Jian Zhang
2026-04-02 15:42 ` [Openipmi-developer] [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove Corey Minyard
2026-04-03  7:23   ` Quan Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=233889df-38ae-4878-afe9-5d23d74be00f@os.amperecomputing.com \
    --to=quan@os.amperecomputing.com \
    --cc=corey@minyard.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=zhangjian.3032@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®