From: Markus Elfring <Markus.Elfring@web.de>
To: Chen Changcheng <chenchangcheng@kylinos.cn>,
linux-media@vger.kernel.org,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: dm1105: fix rc_dev leak on probe error paths
Date: Fri, 23 Oct 2026 20:30:13 +0200 [thread overview]
Message-ID: <6217c190-e8f1-4faa-b934-b1774501a3af@web.de> (raw)
In-Reply-To: <20261022013811.27947-1-chenchangcheng@kylinos.cn>
> dm1105_ir_init() registers an rc_dev that must be cleaned up by
> dm1105_ir_exit(). However, in dm1105_probe() the return value of
> dm1105_ir_init() is ignored, and neither the workqueue nor the
> request_irq error path calls dm1105_ir_exit(). If IR initialization
> succeeds but a later step (create_singlethread_workqueue or
> request_irq) fails, the registered rc_dev is leaked.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.3#n34
Regards,
Markus
prev parent reply other threads:[~2026-10-23 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 1:38 Chen Changcheng
2026-10-23 18:30 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6217c190-e8f1-4faa-b934-b1774501a3af@web.de \
--to=markus.elfring@web.de \
--cc=chenchangcheng@kylinos.cn \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®