From: Valdis.Kletnieks@vt.edu
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Uninline kcalloc()
Date: Mon, 24 Sep 2007 04:13:19 -0400 [thread overview]
Message-ID: <6227.1190621599@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 24 Sep 2007 11:44:35 +0400." <b6fcc0a0709240044x62369dbcv1b5c69ce0be68581@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Mon, 24 Sep 2007 11:44:35 +0400, Alexey Dobriyan said:
> Interesting. Here is output from kernel with patch applied and leak
> plugged into proc_dointvec() (I checked twice):
>
> $ grep kcalloc /proc/slab_allocators
> $ grep proc_dointvec /proc/slab_allocators
> size-64: 19 proc_dointvec+0x48/0xa0
Argh, went to "cancel" that previous msg and retry when I realized you meant it was
with *your* patch installed, managed to send it anyhow..
I wonder if the only reason it's working for you is because gcc is doing
some tail-recursion magic on the kcalloc() call (which calls to __kmalloc),
which just happens to make it work, and if the tail-recursion wasn't happening
it would be busticated.
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2007-09-24 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 20:03 Alexey Dobriyan
2007-09-24 5:35 ` Valdis.Kletnieks
2007-09-24 6:22 ` Jan Engelhardt
2007-09-24 7:24 ` Valdis.Kletnieks
2007-09-24 7:44 ` Alexey Dobriyan
2007-09-24 7:55 ` Valdis.Kletnieks
2007-09-24 8:13 ` Valdis.Kletnieks [this message]
2007-09-24 12:59 ` Kyle Moffett
2007-09-24 13:17 ` Valdis.Kletnieks
2007-09-25 21:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6227.1190621599@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®