From: "Alexey Dobriyan" <adobriyan@gmail.com>
To: Valdis.Kletnieks@vt.edu
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Uninline kcalloc()
Date: Mon, 24 Sep 2007 11:44:35 +0400 [thread overview]
Message-ID: <b6fcc0a0709240044x62369dbcv1b5c69ce0be68581@mail.gmail.com> (raw)
In-Reply-To: <25045.1190612108@turing-police.cc.vt.edu>
On 9/24/07, Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> wrote:
> On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said:
>
> > -static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> > -{
> > - if (n != 0 && size > ULONG_MAX / n)
> > - return NULL;
> > - return __kmalloc(n * size, flags | __GFP_ZERO);
> > -}
> > +void *kcalloc(size_t n, size_t size, gfp_t flags);
>
> NAK.
>
> This busticates some pretty subtle code in mm/slab.c that uses
> uses __builtin_return_address() for debugging
Interesting. Here is output from kernel with patch applied and leak
plugged into proc_dointvec() (I checked twice):
$ grep kcalloc /proc/slab_allocators
$ grep proc_dointvec /proc/slab_allocators
size-64: 19 proc_dointvec+0x48/0xa0
next prev parent reply other threads:[~2007-09-24 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 20:03 Alexey Dobriyan
2007-09-24 5:35 ` Valdis.Kletnieks
2007-09-24 6:22 ` Jan Engelhardt
2007-09-24 7:24 ` Valdis.Kletnieks
2007-09-24 7:44 ` Alexey Dobriyan [this message]
2007-09-24 7:55 ` Valdis.Kletnieks
2007-09-24 8:13 ` Valdis.Kletnieks
2007-09-24 12:59 ` Kyle Moffett
2007-09-24 13:17 ` Valdis.Kletnieks
2007-09-25 21:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fcc0a0709240044x62369dbcv1b5c69ce0be68581@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®