Re: [PATCH v13 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Pankaj Raghav <p.raghav@samsung.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: <hch@lst.de>, <agk@redhat.com>,
	<damien.lemoal@opensource.wdc.com>, <axboe@kernel.dk>,
	<snitzer@kernel.org>, <linux-kernel@vger.kernel.org>,
	<Johannes.Thumshirn@wdc.com>, <linux-nvme@lists.infradead.org>,
	<pankydev8@gmail.com>, <matias.bjorling@wdc.com>,
	<linux-block@vger.kernel.org>, <bvanassche@acm.org>,
	<gost.dev@samsung.com>, <dm-devel@redhat.com>, <hare@suse.de>,
	<jaegeuk@kernel.org>, Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH v13 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes
Date: Fri, 16 Sep 2022 19:57:19 +0200	[thread overview]
Message-ID: <622ae86d-39ad-c45e-ec48-42abf4b257d2@samsung.com> (raw)
In-Reply-To: <e42a0579-61b2-7b77-08cb-6723278490cc@samsung.com>

>>
>> Are you certain you shouldn't at least be exposing a different
>> logical_block_size to upper layers?
>>
> To be honest, I tested my patches in QEMU with 4k Logical block size and on
> a device with 4k LBA size.
> 
> I did a quick test with 512B LBA size in QEMU, and I didn't see any
> failures when I ran my normal test suite.
> 
> Do you see any problem with exposing the same LBA as the underlying device?
> 

Do you see any issues here? If not, I can send the next version with the
other two changes you suggested.

Thanks,
Pankaj

next prev parent reply	other threads:[~2022-09-16 17:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220912082205eucas1p1e5fb1acfb0b2a2fe6261520ace90c883@eucas1p1.samsung.com>
2022-09-12  8:21 ` [PATCH v13 00/13] support zoned block devices with non-power-of-2 " Pankaj Raghav
     [not found]   ` <CGME20220912082206eucas1p25336d07279850f7009be6b5d1fccf558@eucas1p2.samsung.com>
2022-09-12  8:21     ` [PATCH v13 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
2022-09-12 10:03       ` Johannes Thumshirn
2022-09-14 17:19       ` Chaitanya Kulkarni
     [not found]   ` <CGME20220912082207eucas1p14b1bcefc6045a0a835e83db8ed810d5e@eucas1p1.samsung.com>
2022-09-12  8:21     ` [PATCH v13 02/13] block: rearrange bdev_{is_zoned,zone_sectors,get_queue} helper in blkdev.h Pankaj Raghav
2022-09-12 10:03       ` Johannes Thumshirn
2022-09-14 17:19       ` Chaitanya Kulkarni
     [not found]   ` <CGME20220912082209eucas1p2747fa09635df54a6c76821585776672f@eucas1p2.samsung.com>
2022-09-12  8:21     ` [PATCH v13 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-09-12 10:04       ` Johannes Thumshirn
     [not found]   ` <CGME20220912082210eucas1p2a27e358b12b0e4b06a7e00938251c90c@eucas1p2.samsung.com>
2022-09-12  8:21     ` [PATCH v13 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
2022-09-14 17:16       ` Chaitanya Kulkarni
     [not found]   ` <CGME20220912082211eucas1p2d7cbc34d8ba679e525442128698a1116@eucas1p2.samsung.com>
2022-09-12  8:21     ` [PATCH v13 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-09-14 17:16       ` Chaitanya Kulkarni
     [not found]   ` <CGME20220912082212eucas1p1032064dd2ac1638d7d18be7e6fe5344e@eucas1p1.samsung.com>
2022-09-12  8:21     ` [PATCH v13 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-12 10:06       ` Johannes Thumshirn
2022-09-14 17:17       ` Chaitanya Kulkarni
     [not found]   ` <CGME20220912082213eucas1p239d6095dab9b042f05efd3a6e82bac9c@eucas1p2.samsung.com>
2022-09-12  8:21     ` [PATCH v13 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
2022-09-12 10:07       ` Johannes Thumshirn
2022-09-14 17:17       ` Chaitanya Kulkarni
     [not found]   ` <CGME20220912082214eucas1p1a5796db60e6972eace43c3ab6976248c@eucas1p1.samsung.com>
2022-09-12  8:21     ` [PATCH v13 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-09-12 10:07       ` Johannes Thumshirn
     [not found]   ` <CGME20220912082216eucas1p1d3068e7578a88007515c2f4f5ebcc2a8@eucas1p1.samsung.com>
2022-09-12  8:22     ` [PATCH v13 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-09-12 10:08       ` Johannes Thumshirn
     [not found]   ` <CGME20220912082217eucas1p15e4ba29d1438990db4acf5c3f6ca5d4f@eucas1p1.samsung.com>
2022-09-12  8:22     ` [PATCH v13 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-12 10:08       ` Johannes Thumshirn
     [not found]   ` <CGME20220912082218eucas1p23b4bcf6d76947724b9a7468a4b82a7f6@eucas1p2.samsung.com>
2022-09-12  8:22     ` [PATCH v13 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
     [not found]   ` <CGME20220912082219eucas1p28467ed150230da8a65e4c957975fe438@eucas1p2.samsung.com>
2022-09-12  8:22     ` [PATCH v13 12/13] dm: introduce DM_EMULATED_ZONES target feature flag Pankaj Raghav
     [not found]   ` <CGME20220912082220eucas1p24605fdcf22aedc4c40d5303da8f17ad5@eucas1p2.samsung.com>
2022-09-12  8:22     ` [PATCH v13 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-14 16:52       ` Mike Snitzer
2022-09-14 19:16         ` Pankaj Raghav
2022-09-16 17:57           ` Pankaj Raghav [this message]
2022-09-16 18:04             ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=622ae86d-39ad-c45e-ec48-42abf4b257d2@samsung.com \
    --to=p.raghav@samsung.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=pankydev8@gmail.com \
    --cc=snitzer@kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®