mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Hayes Wang <hayeswang@realtek.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
	nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2 2/3] r8152: fix the poor throughput for 2.5G devices
Date: Thu, 27 Apr 2023 14:25:03 +0200	[thread overview]
Message-ID: <622f88b1-9607-48d6-b44d-8aeec8acfd34@lunn.ch> (raw)
In-Reply-To: <20230427121057.29155-407-nic_swsd@realtek.com>

> @@ -7554,6 +7558,11 @@ static void r8156_hw_phy_cfg(struct r8152 *tp)
>  				      ((swap_a & 0x1f) << 8) |
>  				      ((swap_a >> 8) & 0x1f));
>  		}
> +
> +		/*  set intr_en[3] */
> +		data = ocp_reg_read(tp, OCP_INTR_EN);
> +		data |= INTR_SPEED_FORCE;

Which is more meaningful, set intr_en[3], or data |= INTR_SPEED_FORCE
I would say the second. The code is now pretty readable, it says
what it is doing. So if you want to add a comment, you really should
be commenting on why, not what.

   Andrew

  reply	other threads:[~2023-04-27 12:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 12:28 [PATCH net 0/3] r8152: fix " Hayes Wang
2023-04-26 12:28 ` [PATCH net 1/3] r8152: fix flow control issue of RTL8156A Hayes Wang
2023-04-27  0:21   ` Andrew Lunn
2023-04-26 12:28 ` [PATCH net 2/3] r8152: fix the poor throughput for 2.5G devices Hayes Wang
2023-04-27  0:26   ` Andrew Lunn
2023-04-26 12:28 ` [PATCH net 3/3] r8152: move setting r8153b_rx_agg_chg_indicate() Hayes Wang
2023-04-27 12:10 ` [PATCH net v2 0/3] r8152: fix 2.5G devices Hayes Wang
2023-04-27 12:10   ` [PATCH net v2 1/3] r8152: fix flow control issue of RTL8156A Hayes Wang
2023-04-27 12:18     ` Andrew Lunn
2023-04-27 12:10   ` [PATCH net v2 2/3] r8152: fix the poor throughput for 2.5G devices Hayes Wang
2023-04-27 12:25     ` Andrew Lunn [this message]
2023-04-27 12:10   ` [PATCH net v2 3/3] r8152: move setting r8153b_rx_agg_chg_indicate() Hayes Wang
2023-04-27 12:28     ` Andrew Lunn
2023-04-27 12:27   ` [PATCH net v2 0/3] r8152: fix 2.5G devices Andrew Lunn
2023-04-28  3:34     ` Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=622f88b1-9607-48d6-b44d-8aeec8acfd34@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®