Re: [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example

[David Heidelberg <david@ixit.cz>]

Thank you,

Reviewed-by: David Heidelberg <david@ixit.cz>

On 24/07/2025 13:13, Krzysztof Kozlowski wrote:
> dynaimage,al3010 and dynaimage,al3320a are I2C devices, so their
> interrupts are not routed to GIC and rarely first interrupt cell is <0>.
> This looks like copy-paste from some SoC block, so drop it and also for
> readability use known defines instead of hard-coding interrupt flag.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   .../devicetree/bindings/iio/light/dynaimage,al3010.yaml         | 2 +-
>   .../devicetree/bindings/iio/light/dynaimage,al3320a.yaml        | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> index f1048c30e73e..1472c997c16f 100644
> --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> @@ -42,6 +42,6 @@ examples:
>               compatible = "dynaimage,al3010";
>               reg = <0x1c>;
>               vdd-supply = <&vdd_reg>;
> -            interrupts = <0 99 4>;
> +            interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
>           };
>       };
> diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> index 8249be99cff9..d06db737cd9e 100644
> --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> @@ -40,6 +40,6 @@ examples:
>               compatible = "dynaimage,al3320a";
>               reg = <0x1c>;
>               vdd-supply = <&vdd_reg>;
> -            interrupts = <0 99 4>;
> +            interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
>           };
>       };

-- 
David Heidelberg