From: David Heidelberg <david@ixit.cz>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lucas Stankus" <lucas.p.stankus@gmail.com>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Dan Robertson" <dan@dlrobertson.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Ondřej Jirman" <megi@xff.cz>,
"Alexandru Tachici" <alexandru.tachici@analog.com>,
"Stefan Popa" <stefan.popa@analog.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
"Alexandru Lazar" <alazar@startmail.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Andreas Klinger" <ak@it-klinger.de>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
Date: Thu, 24 Jul 2025 13:19:58 +0200 [thread overview]
Message-ID: <d8be9f32-e78d-4a2d-8ab3-3c7d0bca4e3b@ixit.cz> (raw)
In-Reply-To: <20250724111345.47889-5-krzysztof.kozlowski@linaro.org>
Reviewed-by: David Heidelberg <david@ixit.cz>
On 24/07/2025 13:13, Krzysztof Kozlowski wrote:
> Drop includes of headers which example code does not use. No functional
> impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml | 1 -
> Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 1 -
> .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 2 --
> Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml | 2 --
> Documentation/devicetree/bindings/iio/light/st,vl6180.yaml | 1 -
> .../bindings/iio/magnetometer/voltafield,af8133j.yaml | 1 -
> Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 1 -
> 20 files changed, 26 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> index 5887021cc90f..3dc973b98f81 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> @@ -37,7 +37,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> index 0c5b64cae965..3a8c69eecfde 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> @@ -57,7 +57,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -73,7 +72,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index 84d949392012..a23a626bfab6 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -56,7 +56,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -72,7 +71,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> index c07261c71013..f39e2912731f 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> @@ -58,7 +58,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -74,7 +73,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> index 62465e36a590..88aa67bf2280 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> @@ -37,7 +37,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -52,7 +51,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> index 457a709b583c..85c9537f1f02 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> @@ -107,7 +107,6 @@ examples:
> };
> };
> - |
> - # include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> index 8723a336229e..c5fedcf998f2 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> @@ -40,7 +40,6 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> index f64d99b35492..53de921768ac 100644
> --- a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> @@ -57,7 +57,6 @@ examples:
> };
> };
> - |
> - # include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> index ddec9747436c..705adbe88def 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> @@ -93,7 +93,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> index 21ee319d4675..62d906e24997 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> @@ -379,7 +379,6 @@ unevaluatedProperties: false
> examples:
> # Example AD7173-8 with external reference connected to REF+/REF-:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
>
> spi {
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> index c28db0d635a0..b9dc04b0d307 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> @@ -278,7 +278,6 @@ examples:
> - |
> #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
> - #include <dt-bindings/interrupt-controller/irq.h>
>
> pmic {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> index 2a8ad4fdfc6b..f0a1347ba4db 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> @@ -50,7 +50,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> index 775eee972b12..044b66a3b00c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> @@ -44,7 +44,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> index bf5a43a81d59..71f9f9b745cb 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> @@ -59,7 +59,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> index 4cacc9948726..3a725ece7ec4 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> @@ -44,7 +44,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index d4d4e5c3d856..119e28a833fd 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> @@ -74,7 +74,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -91,7 +90,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> index 688100b240bc..2930b3386703 100644
> --- a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> @@ -47,7 +47,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -63,7 +62,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> index 27c36ab7990d..8598fb631aac 100644
> --- a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> @@ -32,7 +32,6 @@ required:
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> index b6ab01a6914a..ed42dc5afb99 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> @@ -44,7 +44,6 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/gpio/gpio.h>
> i2c {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index 706b7e24f182..b9ea37317b53 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -109,7 +109,6 @@ examples:
> };
> - |
> # include <dt-bindings/gpio/gpio.h>
> - # include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
--
David Heidelberg
next prev parent reply other threads:[~2025-07-24 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 11:13 Krzysztof Kozlowski
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:30 ` Matti Vaittinen
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
2025-07-25 3:34 ` Alim Akhtar
2025-07-25 4:34 ` Sam Protsenko
2025-07-25 23:15 ` Rob Herring (Arm)
2025-07-24 11:13 ` [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example Krzysztof Kozlowski
2025-07-24 11:22 ` David Heidelberg
2025-07-25 23:16 ` Rob Herring (Arm)
2025-07-24 11:19 ` David Heidelberg [this message]
2025-07-24 11:30 ` [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Jonathan Cameron
2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:33 ` Matti Vaittinen
2025-07-28 13:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8be9f32-e78d-4a2d-8ab3-3c7d0bca4e3b@ixit.cz \
--to=david@ixit.cz \
--cc=Michael.Hennerich@analog.com \
--cc=agross@kernel.org \
--cc=ak@it-klinger.de \
--cc=alazar@startmail.com \
--cc=alexandru.tachici@analog.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=andy@kernel.org \
--cc=angelo.compagnucci@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dan@dlrobertson.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=dumitru.ceclan@analog.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=mani@kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=megi@xff.cz \
--cc=mike.looijmans@topic.nl \
--cc=nuno.sa@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=puranjay@kernel.org \
--cc=robh@kernel.org \
--cc=stefan.popa@analog.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®