* [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static
@ 2018-03-30 2:25 Wei Yongjun
2018-04-02 18:03 ` Felix Kuehling
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2018-03-30 2:25 UTC (permalink / raw)
To: oded.gabbay, alexander.deucher, christian.koenig, David1.Zhou,
airlied, Felix Kuehling
Cc: Wei Yongjun, dri-devel, amd-gfx, linux-kernel, kernel-janitors
Fixes the following sparse warning:
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index cd679cf..fb5d997 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, struct kfd_process *p,
return ret;
}
-bool kfd_dev_is_large_bar(struct kfd_dev *dev)
+static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
{
struct kfd_local_mem_info mem_info;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static
2018-03-30 2:25 [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static Wei Yongjun
@ 2018-04-02 18:03 ` Felix Kuehling
2018-04-24 9:13 ` Oded Gabbay
0 siblings, 1 reply; 3+ messages in thread
From: Felix Kuehling @ 2018-04-02 18:03 UTC (permalink / raw)
To: Wei Yongjun, oded.gabbay, alexander.deucher, christian.koenig,
David1.Zhou, airlied
Cc: dri-devel, amd-gfx, linux-kernel, kernel-janitors
This patch is Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
On 2018-03-29 10:25 PM, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
> symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index cd679cf..fb5d997 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, struct kfd_process *p,
> return ret;
> }
>
> -bool kfd_dev_is_large_bar(struct kfd_dev *dev)
> +static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
> {
> struct kfd_local_mem_info mem_info;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static
2018-04-02 18:03 ` Felix Kuehling
@ 2018-04-24 9:13 ` Oded Gabbay
0 siblings, 0 replies; 3+ messages in thread
From: Oded Gabbay @ 2018-04-24 9:13 UTC (permalink / raw)
To: Felix Kuehling
Cc: Wei Yongjun, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie,
Maling list - DRI developers, amd-gfx list,
Linux-Kernel@Vger. Kernel. Org, kernel-janitors
On Mon, Apr 2, 2018 at 9:03 PM, Felix Kuehling <felix.kuehling@amd.com> wrote:
> This patch is Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
>
>
> On 2018-03-29 10:25 PM, Wei Yongjun wrote:
>> Fixes the following sparse warning:
>>
>> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
>> symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> index cd679cf..fb5d997 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> @@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, struct kfd_process *p,
>> return ret;
>> }
>>
>> -bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>> +static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>> {
>> struct kfd_local_mem_info mem_info;
>>
>
Thanks, already applied the fix from the kbuild robot.
Oded
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-24 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30 2:25 [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static Wei Yongjun
2018-04-02 18:03 ` Felix Kuehling
2018-04-24 9:13 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®