* [PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox()
@ 2024-07-12 14:06 Dan Carpenter
2024-07-15 1:54 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-07-12 14:06 UTC (permalink / raw)
To: Srujana Challa
Cc: vattunuru, Michael S. Tsirkin, Jason Wang, Xuan Zhuo,
Eugenio Pérez, Shijith Thotton, Nithin Dabilpuram,
virtualization, linux-kernel, kernel-janitors
Return -EINVAL for invalid signatures. Don't return success.
Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
Nag mode: When we add a new driver, then could we use the patch prefix for the
driver not for the subsystem only.
BAD: net: add driver for abc123
GOOD: net/abc123: add driver for abc123
drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
index 7fa0491bb201..11bd76ae18cf 100644
--- a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
+++ b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
@@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu
val = octep_read_sig(mbox);
if ((val & 0xFFFF) != MBOX_RSP_SIG) {
dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);
- return ret;
+ return -EINVAL;
}
val = octep_read_sts(mbox);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox()
2024-07-12 14:06 [PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox() Dan Carpenter
@ 2024-07-15 1:54 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2024-07-15 1:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Srujana Challa, vattunuru, Michael S. Tsirkin, Xuan Zhuo,
Eugenio Pérez, Shijith Thotton, Nithin Dabilpuram,
virtualization, linux-kernel, kernel-janitors
On Fri, Jul 12, 2024 at 10:06 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Return -EINVAL for invalid signatures. Don't return success.
>
> Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> Nag mode: When we add a new driver, then could we use the patch prefix for the
> driver not for the subsystem only.
>
> BAD: net: add driver for abc123
> GOOD: net/abc123: add driver for abc123
>
> drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
> index 7fa0491bb201..11bd76ae18cf 100644
> --- a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
> +++ b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
> @@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu
> val = octep_read_sig(mbox);
> if ((val & 0xFFFF) != MBOX_RSP_SIG) {
> dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);
> - return ret;
> + return -EINVAL;
> }
>
> val = octep_read_sts(mbox);
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-15 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-12 14:06 [PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox() Dan Carpenter
2024-07-15 1:54 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®