* [PATCH] PM / devfreq: Fix kernel warning with cpufreq passive register fail
@ 2022-06-19 22:29 Christian Marangi
2022-06-29 21:33 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Christian Marangi @ 2022-06-19 22:29 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Sibi Sankar,
Saravana Kannan, linux-pm, linux-kernel
Cc: Christian Marangi
Remove cpufreq_passive_unregister_notifier from
cpufreq_passive_register_notifier in case of error as devfreq core
already call unregister on GOV_START fail.
This fix the kernel always printing a WARN on governor PROBE_DEFER as
cpufreq_passive_unregister_notifier is called two times and return
error on the second call as the cpufreq is already unregistered.
Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/devfreq/governor_passive.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
index 72c67979ebe1..8055801cf182 100644
--- a/drivers/devfreq/governor_passive.c
+++ b/drivers/devfreq/governor_passive.c
@@ -336,7 +336,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
err_put_policy:
cpufreq_cpu_put(policy);
err:
- WARN_ON(cpufreq_passive_unregister_notifier(devfreq));
return ret;
}
--
2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: Fix kernel warning with cpufreq passive register fail
2022-06-19 22:29 [PATCH] PM / devfreq: Fix kernel warning with cpufreq passive register fail Christian Marangi
@ 2022-06-29 21:33 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2022-06-29 21:33 UTC (permalink / raw)
To: Christian Marangi, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
Sibi Sankar, Saravana Kannan, linux-pm, linux-kernel
On 22. 6. 20. 07:29, Christian Marangi wrote:
> Remove cpufreq_passive_unregister_notifier from
> cpufreq_passive_register_notifier in case of error as devfreq core
> already call unregister on GOV_START fail.
>
> This fix the kernel always printing a WARN on governor PROBE_DEFER as
> cpufreq_passive_unregister_notifier is called two times and return
> error on the second call as the cpufreq is already unregistered.
>
> Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/devfreq/governor_passive.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
> index 72c67979ebe1..8055801cf182 100644
> --- a/drivers/devfreq/governor_passive.c
> +++ b/drivers/devfreq/governor_passive.c
> @@ -336,7 +336,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
> err_put_policy:
> cpufreq_cpu_put(policy);
> err:
> - WARN_ON(cpufreq_passive_unregister_notifier(devfreq));
>
> return ret;
> }
Applied. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-19 22:29 [PATCH] PM / devfreq: Fix kernel warning with cpufreq passive register fail Christian Marangi
2022-06-29 21:33 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®