mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@gmail.com>
To: Paul Jackson <pj@sgi.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [RFC] HOWTO do Linux kernel development
Date: Mon, 14 Nov 2005 20:52:55 -0600	[thread overview]
Message-ID: <625fc13d0511141852t1daeb059p97e6ef4f535bda20@mail.gmail.com> (raw)
In-Reply-To: <20051114184205.073692cd.pj@sgi.com>

On 11/14/05, Paul Jackson <pj@sgi.com> wrote:
> > Apparently that isn't my forte.
>
> It may well be your forte.  I was commenting on your post, not on you.

How about this:

The goal of the kernel community is to provide the best possible
kernel there is.  When you submit a patch for acceptance, it will be
reviewed on it's technical merits and those alone.  So, what should
you be expecting?

- criticism,
- comments
- requests for change
- requests justification.

Remember, this is part of getting your patch into the kernel.  You
have to be able to take criticism and comments about your patches,
evaluate them at a technical level and either rework your patches or
provide clear and concise reasoning as to why those changes should not
be made.

What should you not do?

- expect your patch to be accepted without question
- become defensive
- ignore comments and resubmit the patch without making any changes
- explain how your project is funded by XYZ and therefore must be
awesome as it is

In a community that is looking for the best technical solution
possible, there will always be differing opinions on how beneficial a
patch is.  You have to be cooperative, and
willing to adapt your idea to fit within the kernel.  Or at least be
willing to prove your idea is worth it.  Remember, being wrong is ok
as long as you are willing to work toward a solution that is right.

josh

  reply	other threads:[~2005-11-15  2:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-14 22:07 Greg KH
2005-11-14 22:10 ` Greg KH
2005-11-14 22:43   ` [RFC] [HUMOR] " Jeffrey V. Merkey
2005-11-15  0:18   ` [RFC] " Kalin KOZHUHAROV
2005-11-15  0:32     ` Randy.Dunlap
2005-11-15  4:58     ` Greg KH
2005-11-15  8:37       ` Paolo Ciarrocchi
2005-11-15 19:04         ` Greg KH
2005-11-15  0:32   ` Josh Boyer
2005-11-15  1:25     ` Paul Jackson
2005-11-15  1:31       ` Randy.Dunlap
2005-11-15  2:16       ` Josh Boyer
2005-11-15  2:42         ` Paul Jackson
2005-11-15  2:52           ` Josh Boyer [this message]
2005-11-15  3:01             ` Paul Jackson
2005-11-15  4:48               ` Greg KH
2005-11-15  4:47             ` Greg KH
2005-11-15  1:08 ` Coywolf Qi Hunt
2005-11-15  4:38   ` Greg KH
2005-11-15  5:51     ` Coywolf Qi Hunt
2005-11-15  5:52       ` Greg KH
2005-11-15  6:31         ` Coywolf Qi Hunt
2005-11-17 13:54         ` Pavel Machek
2005-11-15 14:42 ` Andi Kleen
2005-11-15 17:33   ` Greg KH
2005-11-16  8:12     ` Michael Kerrisk
2005-11-17  6:56       ` Greg KH
2005-11-17 12:12         ` Michael Kerrisk
2005-11-15 20:10 ` Luca
2005-11-15 20:13   ` Josh Boyer
2005-11-15 20:56   ` Greg KH
2005-11-16  4:38     ` Randy.Dunlap
2005-11-15 22:20   ` sitexec
2005-11-16 12:15 linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=625fc13d0511141852t1daeb059p97e6ef4f535bda20@mail.gmail.com \
    --to=jwboyer@gmail.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome