mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mtd: SC520CDP should depend on MTD_CONCAT
@ 2006-04-29 10:41 Daniel Drake
  2006-04-29 13:52 ` Josh Boyer
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Drake @ 2006-04-29 10:41 UTC (permalink / raw)
  To: dwmw2; +Cc: linux-kernel, linux-mtd, toralf.foerster

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

Toralf Förster found a compile error when CONFIG_MTD_SC520CDP=y and
CONFIG_MTD_CONCAT=n:

drivers/built-in.o: In function `init_sc520cdp':
sc520cdp.c:(.init.text+0xb4de): undefined reference to `mtd_concat_create'
drivers/built-in.o: In function `cleanup_sc520cdp':
sc520cdp.c:(.exit.text+0x14bc): undefined reference to `mtd_concat_destroy'

This patch fixes it.

Signed-off-by: Daniel Drake <dsd@gentoo.org>

Index: linux-2.6.17-rc3-test/drivers/mtd/maps/Kconfig
===================================================================
--- linux-2.6.17-rc3-test.orig/drivers/mtd/maps/Kconfig
+++ linux-2.6.17-rc3-test/drivers/mtd/maps/Kconfig
@@ -78,7 +78,7 @@ config MTD_PNC2000
 
 config MTD_SC520CDP
 	tristate "CFI Flash device mapped on AMD SC520 CDP"
-	depends on X86 && MTD_CFI
+	depends on X86 && MTD_CFI && MTD_CONCAT
 	help
 	  The SC520 CDP board has two banks of CFI-compliant chips and one
 	  Dual-in-line JEDEC chip. This 'mapping' driver supports that

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: SC520CDP should depend on MTD_CONCAT
  2006-04-29 10:41 [PATCH] mtd: SC520CDP should depend on MTD_CONCAT Daniel Drake
@ 2006-04-29 13:52 ` Josh Boyer
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Boyer @ 2006-04-29 13:52 UTC (permalink / raw)
  To: Daniel Drake; +Cc: dwmw2, linux-kernel, linux-mtd, toralf.foerster

On 4/29/06, Daniel Drake <dsd@gentoo.org> wrote:
> Toralf Förster found a compile error when CONFIG_MTD_SC520CDP=y and
> CONFIG_MTD_CONCAT=n:
>
> drivers/built-in.o: In function `init_sc520cdp':
> sc520cdp.c:(.init.text+0xb4de): undefined reference to `mtd_concat_create'
> drivers/built-in.o: In function `cleanup_sc520cdp':
> sc520cdp.c:(.exit.text+0x14bc): undefined reference to `mtd_concat_destroy'
>
> This patch fixes it.
>
> Signed-off-by: Daniel Drake <dsd@gentoo.org>

I added this in my tree.  Thanks!

josh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-29 13:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-29 10:41 [PATCH] mtd: SC520CDP should depend on MTD_CONCAT Daniel Drake
2006-04-29 13:52 ` Josh Boyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®