mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fill more device IDS in the structure of m25p80 driver
@ 2006-09-04  8:46 Aubrey
  2006-09-04 13:05 ` Josh Boyer
  0 siblings, 1 reply; 2+ messages in thread
From: Aubrey @ 2006-09-04  8:46 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-mtd

Hi all,

the structure:
struct flash_info __devinitdata m25p_data [] = {
/* REVISIT: fill in JEDEC ids, for parts that have them */
...
};

has a bunch of missing fields (like the JEDEC ids indicated) ... this
causes problems when actually trying to use some ST parts as it gets
detected incorrectly

The following is the patch.
----------------------------------------------------------------------
Signed-off-by: Aubrey L1 <aubreylee@gmail.com>
---

 * Fill more device IDS in the structure of m25p80 driver.
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index a846614..ef4a731 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -406,13 +406,13 @@ struct flash_info {

 static struct flash_info __devinitdata m25p_data [] = {
        /* REVISIT: fill in JEDEC ids, for parts that have them */
-       { "m25p05", 0x05, 0x0000, 32 * 1024, 2 },
-       { "m25p10", 0x10, 0x0000, 32 * 1024, 4 },
-       { "m25p20", 0x11, 0x0000, 64 * 1024, 4 },
-       { "m25p40", 0x12, 0x0000, 64 * 1024, 8 },
+       { "m25p05", 0x05, 0x2010, 32 * 1024, 2 },
+       { "m25p10", 0x10, 0x2011, 32 * 1024, 4 },
+       { "m25p20", 0x11, 0x2012, 64 * 1024, 4 },
+       { "m25p40", 0x12, 0x2013, 64 * 1024, 8 },
        { "m25p80", 0x13, 0x0000, 64 * 1024, 16 },
-       { "m25p16", 0x14, 0x0000, 64 * 1024, 32 },
-       { "m25p32", 0x15, 0x0000, 64 * 1024, 64 },
+       { "m25p16", 0x14, 0x2015, 64 * 1024, 32 },
+       { "m25p32", 0x15, 0x2016, 64 * 1024, 64 },
        { "m25p64", 0x16, 0x2017, 64 * 1024, 128 },
 };

Regards,
-Aubrey

-- 
VGER BF report: H 0.283918

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fill more device IDS in the structure of m25p80 driver
  2006-09-04  8:46 [PATCH] Fill more device IDS in the structure of m25p80 driver Aubrey
@ 2006-09-04 13:05 ` Josh Boyer
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Boyer @ 2006-09-04 13:05 UTC (permalink / raw)
  To: Aubrey; +Cc: linux-kernel, linux-mtd

On 9/4/06, Aubrey <aubreylee@gmail.com> wrote:
> Hi all,
>
> the structure:
> struct flash_info __devinitdata m25p_data [] = {
> /* REVISIT: fill in JEDEC ids, for parts that have them */
> ...
> };
>
> has a bunch of missing fields (like the JEDEC ids indicated) ... this
> causes problems when actually trying to use some ST parts as it gets
> detected incorrectly
>
> The following is the patch.

The patch appears to have corrupted whitespace.  Your mailer probably
mangled it.  Care to try and fix it and resend?

thx,
josh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-09-04 13:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-04  8:46 [PATCH] Fill more device IDS in the structure of m25p80 driver Aubrey
2006-09-04 13:05 ` Josh Boyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®